Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Side by Side Diff: Source/core/dom/ContainerNode.cpp

Issue 178613003: Make Document::nodeChildrenWillBeRemoved() take a reference (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Use PassRefPtr Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/dom/Document.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 510 matching lines...) Expand 10 before | Expand all | Expand 10 after
521 // or widget updates (e.g., for <embed>). 521 // or widget updates (e.g., for <embed>).
522 SubframeLoadingDisabler disabler(*this); 522 SubframeLoadingDisabler disabler(*this);
523 523
524 // Exclude this node when looking for removed focusedElement since only 524 // Exclude this node when looking for removed focusedElement since only
525 // children will be removed. 525 // children will be removed.
526 // This must be later than willRemoveChildren, which might change focus 526 // This must be later than willRemoveChildren, which might change focus
527 // state of a child. 527 // state of a child.
528 document().removeFocusedElementOfSubtree(this, true); 528 document().removeFocusedElementOfSubtree(this, true);
529 529
530 // Removing a node from a selection can cause widget updates. 530 // Removing a node from a selection can cause widget updates.
531 document().nodeChildrenWillBeRemoved(this); 531 document().nodeChildrenWillBeRemoved(*this);
532 } 532 }
533 533
534 534
535 NodeVector removedChildren; 535 NodeVector removedChildren;
536 { 536 {
537 RenderWidget::UpdateSuspendScope suspendWidgetHierarchyUpdates; 537 RenderWidget::UpdateSuspendScope suspendWidgetHierarchyUpdates;
538 { 538 {
539 NoEventDispatchAssertion assertNoEventDispatch; 539 NoEventDispatchAssertion assertNoEventDispatch;
540 removedChildren.reserveInitialCapacity(countChildren()); 540 removedChildren.reserveInitialCapacity(countChildren());
541 while (m_firstChild) { 541 while (m_firstChild) {
(...skipping 504 matching lines...) Expand 10 before | Expand all | Expand 10 after
1046 return true; 1046 return true;
1047 1047
1048 if (node->isElementNode() && toElement(node)->shadow()) 1048 if (node->isElementNode() && toElement(node)->shadow())
1049 return true; 1049 return true;
1050 1050
1051 return false; 1051 return false;
1052 } 1052 }
1053 #endif 1053 #endif
1054 1054
1055 } // namespace WebCore 1055 } // namespace WebCore
OLDNEW
« no previous file with comments | « no previous file | Source/core/dom/Document.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698