Dispatch input event for Range element keyboard event

Dispatch input event for Range element keyboard event

For any value update, dispatch both input and change event.

Also removes extra dispatch change event, as event are dispatch from TextFieldInputType:setValue.

R=tkent, keishi1
BUG=345611
TEST=On keyboard event, both oninput and onchange event are triggered

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168558

[Habib Virji, 2014-02-25 16:42:21]

Send both input and change event.

Removes extra change event getting dispatched.

[ltilve, 2014-02-25 23:52:20]

https://codereview.chromium.org/178593003/diff/1/LayoutTests/fast/forms/range...
File LayoutTests/fast/forms/range/range-keyboard-oninput-event.html (right):

https://codereview.chromium.org/178593003/diff/1/LayoutTests/fast/forms/range...
LayoutTests/fast/forms/range/range-keyboard-oninput-event.html:27: </hefad>
I think that you have a typo here.

[Habib Virji, 2014-02-26 08:52:57]

Thanks. Yes it was typo.

https://codereview.chromium.org/178593003/diff/1/LayoutTests/fast/forms/range...
File LayoutTests/fast/forms/range/range-keyboard-oninput-event.html (right):

https://codereview.chromium.org/178593003/diff/1/LayoutTests/fast/forms/range...
LayoutTests/fast/forms/range/range-keyboard-oninput-event.html:27: </hefad>
On 2014/02/25 23:52:21, ltilve wrote:
> I think that you have a typo here.

Done.

[keishi, 2014-03-03 06:51:11]

https://codereview.chromium.org/178593003/diff/20001/LayoutTests/fast/forms/r...
File LayoutTests/fast/forms/range/range-keyboard-oninput-event.html (right):

https://codereview.chromium.org/178593003/diff/20001/LayoutTests/fast/forms/r...
LayoutTests/fast/forms/range/range-keyboard-oninput-event.html:6: var event =
document.createEvent('KeyboardEvent');
I'm not sure if we will keep allow triggering of default behavior using JS
created keyboard events. I think using eventSender.keyDown will be more
reliable.

https://codereview.chromium.org/178593003/diff/20001/LayoutTests/fast/forms/r...
LayoutTests/fast/forms/range/range-keyboard-oninput-event.html:30: <input
type="range" id="slider" oninput="log('input')" onchange="log('change')"  min=0
max=100 value=50>
I would prefer using js-test.js so we are clear what a passing test is.

[Habib Virji, 2014-03-04 10:32:51]

Updated tests by using js-tests and using eventSender.keyDown

https://codereview.chromium.org/178593003/diff/20001/LayoutTests/fast/forms/r...
File LayoutTests/fast/forms/range/range-keyboard-oninput-event.html (right):

https://codereview.chromium.org/178593003/diff/20001/LayoutTests/fast/forms/r...
LayoutTests/fast/forms/range/range-keyboard-oninput-event.html:6: var event =
document.createEvent('KeyboardEvent');
On 2014/03/03 06:51:11, keishi1 wrote:
> I'm not sure if we will keep allow triggering of default behavior using JS
> created keyboard events. I think using eventSender.keyDown will be more
> reliable.

Done.

https://codereview.chromium.org/178593003/diff/20001/LayoutTests/fast/forms/r...
LayoutTests/fast/forms/range/range-keyboard-oninput-event.html:30: <input
type="range" id="slider" oninput="log('input')" onchange="log('change')"  min=0
max=100 value=50>
On 2014/03/03 06:51:11, keishi1 wrote:
> I would prefer using js-test.js so we are clear what a passing test is.

Done.

[keishi, 2014-03-04 10:47:22]

https://codereview.chromium.org/178593003/diff/40001/LayoutTests/fast/forms/r...
File LayoutTests/fast/forms/range/range-keyboard-oninput-event.html (right):

https://codereview.chromium.org/178593003/diff/40001/LayoutTests/fast/forms/r...
LayoutTests/fast/forms/range/range-keyboard-oninput-event.html:15: {
nit: no line break before bracket in JS. Ditto for other places.

https://codereview.chromium.org/178593003/diff/40001/LayoutTests/fast/forms/r...
LayoutTests/fast/forms/range/range-keyboard-oninput-event.html:18: if (msg ==
'input')
Should be 'change'.

nit: You could use event.type

[Habib Virji, 2014-03-04 11:33:34]

Updated code to use event.type and corrected format

https://codereview.chromium.org/178593003/diff/40001/LayoutTests/fast/forms/r...
File LayoutTests/fast/forms/range/range-keyboard-oninput-event.html (right):

https://codereview.chromium.org/178593003/diff/40001/LayoutTests/fast/forms/r...
LayoutTests/fast/forms/range/range-keyboard-oninput-event.html:15: {
On 2014/03/04 10:47:22, keishi1 wrote:
> nit: no line break before bracket in JS. Ditto for other places.

Done.

https://codereview.chromium.org/178593003/diff/40001/LayoutTests/fast/forms/r...
LayoutTests/fast/forms/range/range-keyboard-oninput-event.html:18: if (msg ==
'input')
On 2014/03/04 10:47:22, keishi1 wrote:
> Should be 'change'.
> 
> nit: You could use event.type

Done.

[keishi, 2014-03-04 13:08:34]

lgtm

[Habib Virji, 2014-03-04 13:15:20]

On 2014/03/04 13:08:34, keishi1 wrote:
> lgtm

thanks keishi

[tkent, 2014-03-04 22:24:28]

lgtm

https://codereview.chromium.org/178593003/diff/60001/LayoutTests/fast/forms/r...
File LayoutTests/fast/forms/range/range-keyboard-oninput-event.html (right):

https://codereview.chromium.org/178593003/diff/60001/LayoutTests/fast/forms/r...
LayoutTests/fast/forms/range/range-keyboard-oninput-event.html:8:
description('Test that for each keyboard event both input and change event are
dispatched');
nit: You don't need to indent the whole content of <script>.
<script>
description(...)
...
function testInput() {
    var slider = ...
    if (window.testRunner) {
        ...
    }
}
testInput();
</script>

[commit-bot: I haz the power, 2014-03-04 22:26:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/habib.virji@samsung.com/178593003/60001

[commit-bot: I haz the power, 2014-03-05 20:54:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/habib.virji@samsung.com/178593003/60001

[commit-bot: I haz the power, 2014-03-06 03:46:29]

Change committed as 168558