LayoutTests/fast/forms/range/range-keyboard-oninput-event.html - Issue 178593003: Dispatch input event for Range element keyboard event

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/forms/range/range-keyboard-oninput-event.html

Issue 178593003: Dispatch input event for Range element keyboard event (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updated tests Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <script src="../../../resources/js-test.js"></script>

	4 </head>

	5 <body>

	6 <input type="range" id="slider" oninput="log('input')" onchange="log('change')" min=0 max=100 value=50>

	7 <script>

	8 description('Test that for each keyboard event both input and change event a re dispatched');

	9 var changeEventCounter = 0;

	10 var lastChangeEventCounter = changeEventCounter;

	11 var inputEventCounter = 0;

	12 var lastInputEventCounter = inputEventCounter;

	13

	14 function log(msg)

	15 {
	keishi 2014/03/04 10:47:22 nit: no line break before bracket in JS. Ditto for nit: no line break before bracket in JS. Ditto for other places. Habib Virji 2014/03/04 11:33:34 Done. Show quoted text On 2014/03/04 10:47:22, keishi1 wrote: > nit: no line break before bracket in JS. Ditto for other places. Done.
	16 if (msg == 'input')

	17 inputEventCounter++;

	18 if (msg == 'input')
	keishi 2014/03/04 10:47:22 Should be 'change'. nit: You could use event.type Should be 'change'. nit: You could use event.type Habib Virji 2014/03/04 11:33:34 Done. Show quoted text On 2014/03/04 10:47:22, keishi1 wrote: > Should be 'change'. > > nit: You could use event.type Done.
	19 changeEventCounter++;

	20 }

	21

	22 function testInput()

	23 {

	24 var slider = document.getElementById('slider');

	25 if (window.testRunner)

	26 {

	27 // slider drag

	28 slider.focus();

	29 debug('Move left');

	30 eventSender.keyDown('leftArrow');

	31 shouldBeGreaterThanOrEqual('inputEventCounter' , 'lastInputEventCoun ter + 1');

	32 shouldBeGreaterThanOrEqual('changeEventCounter', 'lastChangeEventCou nter + 1');

	33 debug('Move right');

	34 lastInputEventCounter = inputEventCounter;

	35 lastChangeEventCounter = changeEventCounter;

	36 eventSender.keyDown('rightArrow');

	37 shouldBeGreaterThanOrEqual('inputEventCounter' , 'lastInputEventCoun ter + 1');

	38 shouldBeGreaterThanOrEqual('changeEventCounter', 'lastChangeEventCou nter + 1');

	39 }

	40 }

	41 testInput();

	42 </script>

	43 </body>

	44 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/forms/range/range-keyboard-oninput-event-expected.txt » ('j') | no next file with comments »