Source/core/html/forms/RangeInputType.cpp - Issue 178593003: Dispatch input event for Range element keyboard event

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/forms/RangeInputType.cpp

Issue 178593003: Dispatch input event for Range element keyboard event (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updated test to use event.type and corrected format Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/forms/range/range-keyboard-oninput-event.html ('K') | « LayoutTests/fast/forms/range/range-keyboard-oninput-event-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/forms/RangeInputType.cpp

diff --git a/Source/core/html/forms/RangeInputType.cpp b/Source/core/html/forms/RangeInputType.cpp

index 55a99154277ea6febb63f2cbbadd3ca24d2fd5f0..af35d482eef7b485f925f443f491175fbf478203 100644

--- a/Source/core/html/forms/RangeInputType.cpp

+++ b/Source/core/html/forms/RangeInputType.cpp

@@ -230,12 +230,11 @@ void RangeInputType::handleKeydownEvent(KeyboardEvent* event)

if (newValue != current) {

EventQueueScope scope;

- TextFieldEventBehavior eventBehavior = DispatchChangeEvent;

+ TextFieldEventBehavior eventBehavior = DispatchInputAndChangeEvent;

setValueAsDecimal(newValue, eventBehavior, IGNORE_EXCEPTION);

if (AXObjectCache* cache = element().document().existingAXObjectCache())

cache->postNotification(&element(), AXObjectCache::AXValueChanged, true);

- element().dispatchFormControlChangeEvent();

}

event->setDefaultHandled();