Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1785633002: Make source information mandatory for building send-like node in CPS (Closed)

Created:
4 years, 9 months ago by Johnni Winther
Modified:
4 years, 9 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make source information mandatory for building send-like node in CPS R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/8738704223a4b65ad1d2ae1a80b6893208241c1a

Patch Set 1 #

Patch Set 2 : Add dartdoc to new methods #

Total comments: 2

Patch Set 3 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+636 lines, -274 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 37 chunks +126 lines, -64 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 1 2 103 chunks +323 lines, -168 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart View 10 chunks +32 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/io/position_information.dart View 1 2 chunks +38 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/io/source_information.dart View 1 1 chunk +36 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/codegen.dart View 10 chunks +31 lines, -15 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart View 7 chunks +16 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart View 8 chunks +34 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
4 years, 9 months ago (2016-03-10 14:21:57 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/1785633002/diff/20001/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart File pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart (right): https://codereview.chromium.org/1785633002/diff/20001/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart#newcode3921 pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart:3921: new Selector.getter(setter.memberName), oh my - did this affect ...
4 years, 9 months ago (2016-03-10 17:49:04 UTC) #3
Johnni Winther
https://codereview.chromium.org/1785633002/diff/20001/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart File pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart (right): https://codereview.chromium.org/1785633002/diff/20001/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart#newcode3921 pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart:3921: new Selector.getter(setter.memberName), On 2016/03/10 17:49:04, Siggi Cherem (dart-lang) wrote: ...
4 years, 9 months ago (2016-03-11 13:46:27 UTC) #4
Johnni Winther
4 years, 9 months ago (2016-03-11 13:56:31 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
8738704223a4b65ad1d2ae1a80b6893208241c1a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698