Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Unified Diff: pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart

Issue 1785633002: Make source information mandatory for building send-like node in CPS (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Updated cf. comments. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart
diff --git a/pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart b/pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart
index b4ca9abe9022563c11f459bfa4650979485af94e..46565ab0cb7bd11dadb8fea619e1ec73944a3251 100644
--- a/pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart
+++ b/pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart
@@ -4,11 +4,13 @@
library tree_ir_builder;
+import 'package:js_ast/js_ast.dart' as js;
+
import '../common.dart';
import '../constants/values.dart';
import '../cps_ir/cps_ir_nodes.dart' as cps_ir;
import '../elements/elements.dart';
-import 'package:js_ast/js_ast.dart' as js;
+import '../io/source_information.dart';
import '../js_backend/codegen/glue.dart';
import 'tree_ir_nodes.dart';
@@ -85,9 +87,10 @@ class Builder implements cps_ir.Visitor/*<NodeCallback|Node>*/ {
}
VariableUse getMutableVariableUse(
- cps_ir.Reference<cps_ir.MutableVariable> reference) {
+ cps_ir.Reference<cps_ir.MutableVariable> reference,
+ SourceInformation sourceInformation) {
Variable variable = getMutableVariable(reference.definition);
- return new VariableUse(variable);
+ return new VariableUse(variable, sourceInformation: sourceInformation);
}
/// Obtains the variable representing the given primitive. Returns null for
@@ -483,7 +486,8 @@ class Builder implements cps_ir.Visitor/*<NodeCallback|Node>*/ {
Expression visitSetField(cps_ir.SetField node) {
return new SetField(getVariableUse(node.objectRef),
node.field,
- getVariableUse(node.valueRef));
+ getVariableUse(node.valueRef),
+ node.sourceInformation);
}
Expression visitInterceptor(cps_ir.Interceptor node) {
@@ -502,7 +506,7 @@ class Builder implements cps_ir.Visitor/*<NodeCallback|Node>*/ {
Expression visitGetField(cps_ir.GetField node) {
return new GetField(getVariableUse(node.objectRef), node.field,
- objectIsNotNull: !node.object.type.isNullable);
+ node.sourceInformation, objectIsNotNull: !node.object.type.isNullable);
}
Expression visitCreateBox(cps_ir.CreateBox node) {
@@ -516,13 +520,14 @@ class Builder implements cps_ir.Visitor/*<NodeCallback|Node>*/ {
}
Expression visitGetMutable(cps_ir.GetMutable node) {
- return getMutableVariableUse(node.variableRef);
+ return getMutableVariableUse(node.variableRef, node.sourceInformation);
}
Expression visitSetMutable(cps_ir.SetMutable node) {
Variable variable = getMutableVariable(node.variable);
Expression value = getVariableUse(node.valueRef);
- return new Assign(variable, value);
+ return new Assign(
+ variable, value, sourceInformation: node.sourceInformation);
}
Expression visitConstant(cps_ir.Constant node) {
@@ -724,7 +729,8 @@ class Builder implements cps_ir.Visitor/*<NodeCallback|Node>*/ {
arguments,
node.nativeBehavior,
nullableArguments,
- node.dependency);
+ node.dependency,
+ node.sourceInformation);
} else {
return (Statement next) {
assert(next is Unreachable); // We are not using the `next` statement.
@@ -734,7 +740,8 @@ class Builder implements cps_ir.Visitor/*<NodeCallback|Node>*/ {
arguments,
node.nativeBehavior,
nullableArguments,
- node.dependency);
+ node.dependency,
+ node.sourceInformation);
};
}
}
« no previous file with comments | « pkg/compiler/lib/src/js_backend/codegen/codegen.dart ('k') | pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698