Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart

Issue 1785633002: Make source information mandatory for building send-like node in CPS (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Updated cf. comments. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart
diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart
index 9649268c4d107a9d6ba32fdcca00d6eb642d4f1b..e637950de73ee99dfc290489cdded4accfccb387 100644
--- a/pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart
+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart
@@ -1113,10 +1113,11 @@ class ApplyBuiltinMethod extends Primitive {
///
class GetMutable extends Primitive {
final Reference<MutableVariable> variableRef;
+ final SourceInformation sourceInformation;
MutableVariable get variable => variableRef.definition;
- GetMutable(MutableVariable variable)
+ GetMutable(MutableVariable variable, {this.sourceInformation})
: this.variableRef = new Reference<MutableVariable>(variable);
accept(Visitor visitor) => visitor.visitGetMutable(this);
@@ -1139,11 +1140,15 @@ class GetMutable extends Primitive {
class SetMutable extends Primitive {
final Reference<MutableVariable> variableRef;
final Reference<Primitive> valueRef;
+ final SourceInformation sourceInformation;
MutableVariable get variable => variableRef.definition;
Primitive get value => valueRef.definition;
- SetMutable(MutableVariable variable, Primitive value)
+ SetMutable(
+ MutableVariable variable,
+ Primitive value,
+ {this.sourceInformation})
: this.variableRef = new Reference<MutableVariable>(variable),
this.valueRef = new Reference<Primitive>(value);
@@ -1165,6 +1170,7 @@ class SetMutable extends Primitive {
class GetField extends Primitive {
final Reference<Primitive> objectRef;
FieldElement field;
+ final SourceInformation sourceInformation;
/// True if the field never changes value.
final bool isFinal;
@@ -1176,7 +1182,11 @@ class GetField extends Primitive {
Primitive get object => objectRef.definition;
- GetField(Primitive object, this.field, {this.isFinal: false})
+ GetField(
+ Primitive object,
+ this.field,
+ {this.sourceInformation,
+ this.isFinal: false})
: this.objectRef = new Reference<Primitive>(object);
accept(Visitor visitor) => visitor.visitGetField(this);
@@ -1199,11 +1209,16 @@ class SetField extends Primitive {
final Reference<Primitive> objectRef;
FieldElement field;
final Reference<Primitive> valueRef;
+ final SourceInformation sourceInformation;
Primitive get object => objectRef.definition;
Primitive get value => valueRef.definition;
- SetField(Primitive object, this.field, Primitive value)
+ SetField(
+ Primitive object,
+ this.field,
+ Primitive value,
+ {this.sourceInformation})
: this.objectRef = new Reference<Primitive>(object),
this.valueRef = new Reference<Primitive>(value);
@@ -1528,13 +1543,18 @@ class ForeignCode extends UnsafePrimitive {
final TypeMask storedType;
final List<Reference<Primitive>> argumentRefs;
final native.NativeBehavior nativeBehavior;
+ final SourceInformation sourceInformation;
final FunctionElement dependency;
Primitive argument(int n) => argumentRefs[n].definition;
Iterable<Primitive> get arguments => _dereferenceList(argumentRefs);
- ForeignCode(this.codeTemplate, this.storedType, List<Primitive> arguments,
+ ForeignCode(
+ this.codeTemplate,
+ this.storedType,
+ List<Primitive> arguments,
this.nativeBehavior,
+ this.sourceInformation,
{this.dependency})
: this.argumentRefs = _referenceList(arguments) {
effects = Effects.from(nativeBehavior.sideEffects);
@@ -2820,7 +2840,8 @@ class DefinitionCopyingVisitor extends Visitor<Definition> {
}
Definition visitSetMutable(SetMutable node) {
- return new SetMutable(getCopy(node.variableRef), getCopy(node.valueRef));
+ return new SetMutable(getCopy(node.variableRef), getCopy(node.valueRef),
+ sourceInformation: node.sourceInformation);
}
Definition visitSetStatic(SetStatic node) {
@@ -2830,7 +2851,8 @@ class DefinitionCopyingVisitor extends Visitor<Definition> {
Definition visitSetField(SetField node) {
return new SetField(
- getCopy(node.objectRef), node.field, getCopy(node.valueRef));
+ getCopy(node.objectRef), node.field, getCopy(node.valueRef),
+ sourceInformation: node.sourceInformation);
}
Definition visitGetLazyStatic(GetLazyStatic node) {
@@ -2856,7 +2878,8 @@ class DefinitionCopyingVisitor extends Visitor<Definition> {
}
Definition visitGetMutable(GetMutable node) {
- return new GetMutable(getCopy(node.variableRef));
+ return new GetMutable(
+ getCopy(node.variableRef), sourceInformation: node.sourceInformation);
}
Definition visitParameter(Parameter node) {
@@ -2972,6 +2995,7 @@ class DefinitionCopyingVisitor extends Visitor<Definition> {
Definition visitForeignCode(ForeignCode node) {
return new ForeignCode(node.codeTemplate, node.storedType,
getList(node.argumentRefs), node.nativeBehavior,
+ node.sourceInformation,
dependency: node.dependency);
}
}
« no previous file with comments | « pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart ('k') | pkg/compiler/lib/src/io/position_information.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698