Complete PBXCopyFilesBuildPhase TODO in xcodeproj_file.py.

Complete PBXCopyFilesBuildPhase TODO in xcodeproj_file.py.

Add the remaining destination-related Xcode build setting names to the
list in class PBXCopyFilesBuildPhase. After this change destinations
can be specified as e.g.

  <(PRODUCT_DIR)/$(PLUGINS_FOLDER_PATH)

and this will work in Xcode, ninja and make. Previously such
destinations would only work in Xcode. Also now Xcode's GUI
will show its human-friendly name for the destination, in
this case "PlugIns". Previously such a destination would show
as "Products Directory" and the Subpath field would show
the rest of the path to the destination.

R=mark@chromium.org

Committed: https://chromium.googlesource.com/external/gyp/+/1f989f652a3017858c1e418c8344f04baee59f51

[marksc2222, 2016-03-12 12:39:32]

marksc2222@gmail.com changed reviewers:
+ mark@chromium.org

[marksc2222, 2016-03-12 12:39:33]

This change completes the TODO at
https://chromium.googlesource.com/external/gyp/+/master/pylib/gyp/xcodeproj_f...

A long time ago I submitted change for this same TODO under an e-mail address to
which I no longer have access. This one is improved in several regards. It makes
these build settings work with ninja and make formats as well as Xcode. It adds
new tests and augments some existing tests.

All existing and new xcode, ninja and make tests pass on OS X.

[marksc2222, 2016-03-12 12:41:34]

Description was changed from

==========
Complete PBXCopyFilesBuildPhase TODO in xcodeproj_file.py.

Add the remaining destination-related Xcode build setting names to the
list in class PBXCopyFilesBuildPhase. After this change destinations
can be specified as e.g.

  <(PRODUCT_DIR)/$PLUGINS_FOLDER_PATH)

and this will work in Xcode, ninja and make. Previously such
destinations would only work in Xcode. Also now Xcode's GUI
will show its human-friendly name for the destination, in
this case "PlugIns". Previously such a destination would show
as "Products Directory" and the Subpath field would show
the rest of the path to the destination.
==========

to

==========
Complete PBXCopyFilesBuildPhase TODO in xcodeproj_file.py.

Add the remaining destination-related Xcode build setting names to the
list in class PBXCopyFilesBuildPhase. After this change destinations
can be specified as e.g.

  <(PRODUCT_DIR)/$(PLUGINS_FOLDER_PATH)

and this will work in Xcode, ninja and make. Previously such
destinations would only work in Xcode. Also now Xcode's GUI
will show its human-friendly name for the destination, in
this case "PlugIns". Previously such a destination would show
as "Products Directory" and the Subpath field would show
the rest of the path to the destination.
==========

[Mark Mentovai, 2016-04-05 00:13:26]

Sorry for the delay, and thanks for the added tests.

Do you have handy a link to the previous review thread for this?

[marksc2222, 2016-04-12 06:23:19]

On 2016/04/05 00:13:26, Mark Mentovai wrote:
> Sorry for the delay, and thanks for the added tests.
> 
> Do you have handy a link to the previous review thread for this?

Here it is: https://codereview.chromium.org/391223002/.

Note that this new version is quite different. In the previous version the Xcode
variable, e.g. $(EXECUTABLE_FOLDER_PATH), was used on its own to specify the
destination in the gyp file. However Xcode defines those variables as relative
to $(BUILT_PRODUCTS_DIR) so I adopted the same approach this time. Now you
specify the destination as $(BUILT_PRODUCTS_DIR)/$(EXECUTABLE_FOLDER_PATH) or
<(PRODUCT_DIR)/$(EXECUTABLE_FOLDER_PATH). There is a long comment in
xcodeproj_file.py explaining more about this.

[Mark Mentovai, 2016-05-06 20:26:54]

Well-done! These are just minor comments.

https://codereview.chromium.org/1785543006/diff/1/test/ios/copies-with-xcode-...
File test/ios/copies-with-xcode-envvars/Info.plist (right):

https://codereview.chromium.org/1785543006/diff/1/test/ios/copies-with-xcode-...
test/ios/copies-with-xcode-envvars/Info.plist:20: <string>ause</string>
Ought to be ????.

Did you copy this from somewhere? Those somewheres should be ???? too.

https://codereview.chromium.org/1785543006/diff/1/test/ios/copies-with-xcode-...
File test/ios/copies-with-xcode-envvars/copies-with-xcode-envvars.gyp (right):

https://codereview.chromium.org/1785543006/diff/1/test/ios/copies-with-xcode-...
test/ios/copies-with-xcode-envvars/copies-with-xcode-envvars.gyp:2: # @internal
Lose this stuff. Any boilerplace at the top of these files should be the block
we use in GYP.

https://codereview.chromium.org/1785543006/diff/1/test/ios/gyptest-copies-wit...
File test/ios/gyptest-copies-with-xcode-envvars.py (right):

https://codereview.chromium.org/1785543006/diff/1/test/ios/gyptest-copies-wit...
test/ios/gyptest-copies-with-xcode-envvars.py:3: # Copyright (C) 2016, Mark
Callow. All rights reserved.
Use the same form we use elsewhere (to make it easier to grep about for these
and apply transformations as needed): lowercase (c) and no comma.

https://codereview.chromium.org/1785543006/diff/1/test/mac/copies-with-xcode-...
File test/mac/copies-with-xcode-envvars/copies-with-xcode-envvars.gyp (right):

https://codereview.chromium.org/1785543006/diff/1/test/mac/copies-with-xcode-...
test/mac/copies-with-xcode-envvars/copies-with-xcode-envvars.gyp:3: # @copyright
© 2016, Mark Callow. For license see LICENSE.md.
Fix. Don’t refer to nonexistent files.

https://codereview.chromium.org/1785543006/diff/1/test/mac/gyptest-copies-wit...
File test/mac/gyptest-copies-with-xcode-envvars.py (right):

https://codereview.chromium.org/1785543006/diff/1/test/mac/gyptest-copies-wit...
test/mac/gyptest-copies-with-xcode-envvars.py:3: # Copyright (C) 2016, Mark
Callow. All rights reserved.
Same.

[marksc2222, 2016-06-20 08:28:06]

On 2016/05/06 20:26:54, Mark Mentovai wrote:
> Well-done! These are just minor comments.
> 

Thanks. I have uploaded a new patch set which fixes these issues. It is also
rebased against today's master branch. Please re-review.

Note that several of the ios tests and one mac+ios test (gyptest-xctest.py)
fail. Since the same set of tests fail in master, the failures clearly have
nothing to do with these changes so there is no point holding them up while
resolving the test issues. The failures must be due either to changes in master
or changes to Xcode in the past 3 months since I last ran the tests. I am now
using Xcode 7.3.1.

[Mark Mentovai, 2016-08-05 03:46:37]

LGTM!

[Mark Mentovai, 2016-08-05 03:47:26]

Description was changed from

==========
Complete PBXCopyFilesBuildPhase TODO in xcodeproj_file.py.

Add the remaining destination-related Xcode build setting names to the
list in class PBXCopyFilesBuildPhase. After this change destinations
can be specified as e.g.

  <(PRODUCT_DIR)/$(PLUGINS_FOLDER_PATH)

and this will work in Xcode, ninja and make. Previously such
destinations would only work in Xcode. Also now Xcode's GUI
will show its human-friendly name for the destination, in
this case "PlugIns". Previously such a destination would show
as "Products Directory" and the Subpath field would show
the rest of the path to the destination.
==========

to

==========
Complete PBXCopyFilesBuildPhase TODO in xcodeproj_file.py.

Add the remaining destination-related Xcode build setting names to the
list in class PBXCopyFilesBuildPhase. After this change destinations
can be specified as e.g.

  <(PRODUCT_DIR)/$(PLUGINS_FOLDER_PATH)

and this will work in Xcode, ninja and make. Previously such
destinations would only work in Xcode. Also now Xcode's GUI
will show its human-friendly name for the destination, in
this case "PlugIns". Previously such a destination would show
as "Products Directory" and the Subpath field would show
the rest of the path to the destination.

R=mark@chromium.org

Committed:
https://chromium.googlesource.com/external/gyp/+/1f989f652a3017858c1e418c8344...
==========

[Mark Mentovai, 2016-08-05 03:47:28]

Committed patchset #2 (id:20001) manually as
1f989f652a3017858c1e418c8344f04baee59f51 (presubmit successful).