test/ios/copies-with-xcode-envvars/Info.plist - Issue 1785543006: Complete PBXCopyFilesBuildPhase TODO in xcodeproj_file.py.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/ios/copies-with-xcode-envvars/Info.plist

Issue 1785543006: Complete PBXCopyFilesBuildPhase TODO in xcodeproj_file.py. (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master

Patch Set: Fix minor issues from code review. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/ios/copies-with-xcode-envvars/Info.plist

diff --git a/test/ios/xctests/AppTests/Info.plist b/test/ios/copies-with-xcode-envvars/Info.plist

similarity index 86%

copy from test/ios/xctests/AppTests/Info.plist

copy to test/ios/copies-with-xcode-envvars/Info.plist

index d43ff4ba8d1ad9f4d18cac73a4f5660168e6abcf..a0985c3e4dbb64257e05031d0641eb8e7a83fc4d 100644

--- a/test/ios/xctests/AppTests/Info.plist

+++ b/test/ios/copies-with-xcode-envvars/Info.plist

@@ -3,17 +3,17 @@

<dict>

<key>CFBundleDevelopmentRegion</key>

- <string>en</string>

+ <string>English</string>

<key>CFBundleExecutable</key>

<string>${EXECUTABLE_NAME}</string>

<key>CFBundleIdentifier</key>

- <string>com.google.gyptest.AppTests</string>

+ <string>$(PRODUCT_BUNDLE_IDENTIFIER)</string>

<key>CFBundleInfoDictionaryVersion</key>

<key>CFBundleName</key>

<string>${PRODUCT_NAME}</string>

<key>CFBundlePackageType</key>

- <string>BNDL</string>

+ <string>APPL</string>

<key>CFBundleShortVersionString</key>

<key>CFBundleSignature</key>

« no previous file with comments | « pylib/gyp/xcodeproj_file.py ('k') | test/ios/copies-with-xcode-envvars/copies-with-xcode-envvars.gyp » ('j') | no next file with comments »