test/mac/type_envvars/test_nonbundle_shared_library.sh - Issue 1785543006: Complete PBXCopyFilesBuildPhase TODO in xcodeproj_file.py.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/mac/type_envvars/test_nonbundle_shared_library.sh

Issue 1785543006: Complete PBXCopyFilesBuildPhase TODO in xcodeproj_file.py. (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master

Patch Set: Fix minor issues from code review. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/mac/type_envvars/test_nonbundle_shared_library.sh

diff --git a/test/mac/type_envvars/test_nonbundle_shared_library.sh b/test/mac/type_envvars/test_nonbundle_shared_library.sh

index cbb118b7b248caed350aaedf642903a686f1c907..ba63ec1a48fa98e705c3f23972b3f07f30a92cf5 100755

--- a/test/mac/type_envvars/test_nonbundle_shared_library.sh

+++ b/test/mac/type_envvars/test_nonbundle_shared_library.sh

@@ -14,6 +14,17 @@ test $EXECUTABLE_NAME = libnonbundle_shared_library.dylib

test $EXECUTABLE_PATH = libnonbundle_shared_library.dylib

[[ ! $WRAPPER_NAME && ${WRAPPER_NAME-_} ]]

+[[ ! $CONTENTS_FOLDER_PATH && ${CONTENTS_FOLDER_PATH-_} ]]

+[[ ! $EXECUTABLE_FOLDER_PATH && ${EXECUTABLE_FOLDER_PATH-_} ]]

+[[ ! $UNLOCALIZED_RESOURCES_FOLDER_PATH && \

+ ${UNLOCALIZED_RESOURCES_FOLDER_PATH-_} ]]

+[[ ! $JAVA_FOLDER_PATH && ${JAVA_FOLDER_PATH-_} ]]

+[[ ! $FRAMEWORKS_FOLDER_PATH && ${FRAMEWORKS_FOLDER_PATH-_} ]]

+[[ ! $SHARED_FRAMEWORKS_FOLDER_PATH && ${SHARED_FRAMEWORKS_FOLDER_PATH-_} ]]

+[[ ! $SHARED_SUPPORT_FOLDER_PATH && ${SHARED_SUPPORT_FOLDER_PATH-_} ]]

+[[ ! $PLUGINS_FOLDER_PATH && ${PLUGINS_FOLDER_PATH-_} ]]

+[[ ! $XPCSERVICES_FOLDER_PATH && ${XPCSERVICES_FOLDER_PATH-_} ]]

test $DYLIB_INSTALL_NAME_BASE = "/usr/local/lib"

test $LD_DYLIB_INSTALL_NAME = "/usr/local/lib/libnonbundle_shared_library.dylib"

« no previous file with comments | « test/mac/type_envvars/test_nonbundle_none.sh ('k') | test/mac/type_envvars/test_nonbundle_static_library.sh » ('j') | no next file with comments »