Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1785533002: [DevTools] Removed unused hidden protocol method: getStepInPositions (Closed)

Created:
4 years, 9 months ago by kozy
Modified:
4 years, 9 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kinuko+watch, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Removed unused hidden protocol method: getStepInPositions UI part of experiment was removed in https://codereview.chromium.org/201293007 TBR=pfeldman@chromium.org Committed: https://crrev.com/14d5f856a124202b6abe25c32630304a7cd256d7 Cr-Commit-Position: refs/heads/master@{#380289}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -157 lines) Patch
M third_party/WebKit/LayoutTests/inspector-protocol/debugger/access-obsolete-frame.html View 2 chunks +8 lines, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/debugger/access-obsolete-frame-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/debugger/getStepInPositions.html View 1 chunk +0 lines, -54 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/debugger/getStepInPositions-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/devtools/protocol.json View 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp View 1 chunk +0 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js View 1 chunk +0 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp View 1 chunk +0 lines, -22 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
kozy
4 years, 9 months ago (2016-03-09 23:07:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1785533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1785533002/1
4 years, 9 months ago (2016-03-09 23:08:51 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-10 01:24:58 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 01:26:49 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/14d5f856a124202b6abe25c32630304a7cd256d7
Cr-Commit-Position: refs/heads/master@{#380289}

Powered by Google App Engine
This is Rietveld 408576698