Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 201293007: DevTools: Remove step into selection experiment (Closed)

Created:
6 years, 9 months ago by vsevik
Modified:
6 years, 9 months ago
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: Remove step into selection experiment R=lushnikov, pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169442

Patch Set 1 #

Total comments: 1

Patch Set 2 : Removed some more code #

Patch Set 3 : Rebaselined #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -405 lines) Patch
M Source/devtools/front_end/DebuggerModel.js View 1 3 chunks +0 lines, -56 lines 0 comments Download
M Source/devtools/front_end/JavaScriptSourceFrame.js View 1 6 chunks +3 lines, -260 lines 0 comments Download
M Source/devtools/front_end/Settings.js View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/ShortcutsScreen.js View 2 chunks +0 lines, -6 lines 0 comments Download
M Source/devtools/front_end/SourcesPanel.js View 1 6 chunks +1 line, -71 lines 0 comments Download
M Source/devtools/front_end/inspector.css View 1 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
vsevik
PTAL
6 years, 9 months ago (2014-03-17 15:44:20 UTC) #1
pfeldman
lgtm
6 years, 9 months ago (2014-03-17 17:50:36 UTC) #2
aandrey
do you plan to clean up the backend code as well? https://codereview.chromium.org/201293007/diff/1/Source/devtools/front_end/JavaScriptSourceFrame.js File Source/devtools/front_end/JavaScriptSourceFrame.js (left): ...
6 years, 9 months ago (2014-03-17 19:05:20 UTC) #3
yurys
Why are you removing it? Has it proved to be useless, hard to maintain or ...
6 years, 9 months ago (2014-03-18 06:07:27 UTC) #4
vsevik
On 2014/03/18 06:07:27, yurys wrote: > Why are you removing it? Has it proved to ...
6 years, 9 months ago (2014-03-18 09:19:52 UTC) #5
vsevik
> do you plan to clean up the backend code as well? Let's do this ...
6 years, 9 months ago (2014-03-18 09:20:17 UTC) #6
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 9 months ago (2014-03-18 09:20:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/201293007/20001
6 years, 9 months ago (2014-03-18 09:20:29 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-18 09:23:05 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_compile_dbg
6 years, 9 months ago (2014-03-18 09:23:06 UTC) #10
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 9 months ago (2014-03-18 09:25:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/201293007/40001
6 years, 9 months ago (2014-03-18 09:25:52 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-18 10:26:19 UTC) #13
Message was sent while issue was closed. 
Change committed as 169442

Powered by Google App Engine
This is Rietveld 408576698