Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp

Issue 1785533002: [DevTools] Removed unused hidden protocol method: getStepInPositions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
index 39c22c28a4036f89315680f7baf02ce011f1f2b7..0db869390761695e3ac12af1954b461eacecd5ac 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
@@ -478,28 +478,6 @@ void V8DebuggerAgentImpl::continueToLocation(ErrorString* errorString,
resume(errorString);
}
-void V8DebuggerAgentImpl::getStepInPositions(ErrorString* errorString, const String16& callFrameId, Maybe<Array<protocol::Debugger::Location>>* positions)
-{
- if (!isPaused() || m_currentCallStack.IsEmpty()) {
- *errorString = "Attempt to access callframe when debugger is not on pause";
- return;
- }
- OwnPtr<RemoteCallFrameId> remoteId = RemoteCallFrameId::parse(callFrameId);
- if (!remoteId) {
- *errorString = "Invalid call frame id";
- return;
- }
- InjectedScript* injectedScript = m_injectedScriptManager->findInjectedScript(remoteId.get());
- if (!injectedScript) {
- *errorString = "Inspected frame has gone";
- return;
- }
-
- v8::HandleScope scope(m_isolate);
- v8::Local<v8::Object> callStack = m_currentCallStack.Get(m_isolate);
- injectedScript->getStepInPositions(errorString, callStack, callFrameId, positions);
-}
-
void V8DebuggerAgentImpl::getBacktrace(ErrorString* errorString, OwnPtr<Array<CallFrame>>* callFrames, Maybe<StackTrace>* asyncStackTrace)
{
if (!assertPaused(errorString))
« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698