Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1785493002:
Move cache clearing from AwRenderViewExt to AwRenderFrameExt. (Closed)
|
Created:
4 years, 9 months ago by Avi (use Gerrit) Modified:
4 years, 9 months ago Reviewers:
boliu CC:
chromium-reviews, android-webview-reviews_chromium.org, site-isolation-reviews_chromium.org, mnaganov (inactive), hush (inactive) Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMove cache clearing from AwRenderViewExt to AwRenderFrameExt.
BUG=593473
TEST=no change
Committed: https://crrev.com/0363eb92d2784e47b4afba897866b24277163111
Cr-Commit-Position: refs/heads/master@{#380494}
Patch Set 1 #Patch Set 2 : new approach #Patch Set 3 : NOT equal... ugh #Patch Set 4 : deps not necessary? #Patch Set 5 : fix #
Total comments: 2
Patch Set 6 : comment #
Messages
Total messages: 33 (16 generated)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1785493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1785493002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by avi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1785493002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1785493002/20001
Description was changed from ========== Move AwRenderViewExt off of RenderViewObserver::Navigate. BUG=593473 TEST=no change ========== to ========== Move cache clearing from AwRenderViewExt to AwRenderFrameExt. BUG=593473 TEST=no change ==========
The CQ bit was checked by avi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1785493002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1785493002/40001
The CQ bit was checked by avi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1785493002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1785493002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1785493002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1785493002/80001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
avi@chromium.org changed reviewers: + boliu@chromium.org
Bo Liu— For your consideration. I tried to achieve better what you were aiming for, a cache flush on origin changes. Let me know what you think.
lgtm https://codereview.chromium.org/1785493002/diff/80001/android_webview/rendere... File android_webview/renderer/aw_render_frame_ext.cc (right): https://codereview.chromium.org/1785493002/diff/80001/android_webview/rendere... android_webview/renderer/aw_render_frame_ext.cc:151: // Clear the cache when we cross site boundaries in the main frame. Can add what we found in the email thread as a comment for the next person? ie goal here is to clear cache when multi-process chrome would have moved to a new renderer process.
The CQ bit was checked by avi@chromium.org to run a CQ dry run
How does that comment look? https://codereview.chromium.org/1785493002/diff/80001/android_webview/rendere... File android_webview/renderer/aw_render_frame_ext.cc (right): https://codereview.chromium.org/1785493002/diff/80001/android_webview/rendere... android_webview/renderer/aw_render_frame_ext.cc:151: // Clear the cache when we cross site boundaries in the main frame. On 2016/03/10 21:59:58, boliu wrote: > Can add what we found in the email thread as a comment for the next person? ie > goal here is to clear cache when multi-process chrome would have moved to a new > renderer process. Done.
On 2016/03/10 22:07:56, Avi wrote: > How does that comment look? looks good :)
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1785493002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1785493002/100001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by avi@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from boliu@chromium.org Link to the patchset: https://codereview.chromium.org/1785493002/#ps100001 (title: "comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1785493002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1785493002/100001
Message was sent while issue was closed.
Description was changed from ========== Move cache clearing from AwRenderViewExt to AwRenderFrameExt. BUG=593473 TEST=no change ========== to ========== Move cache clearing from AwRenderViewExt to AwRenderFrameExt. BUG=593473 TEST=no change ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== Move cache clearing from AwRenderViewExt to AwRenderFrameExt. BUG=593473 TEST=no change ========== to ========== Move cache clearing from AwRenderViewExt to AwRenderFrameExt. BUG=593473 TEST=no change Committed: https://crrev.com/0363eb92d2784e47b4afba897866b24277163111 Cr-Commit-Position: refs/heads/master@{#380494} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/0363eb92d2784e47b4afba897866b24277163111 Cr-Commit-Position: refs/heads/master@{#380494} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
