Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1096)

Unified Diff: android_webview/renderer/aw_render_view_ext.cc

Issue 1785493002: Move cache clearing from AwRenderViewExt to AwRenderFrameExt. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comment Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/renderer/aw_render_view_ext.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/renderer/aw_render_view_ext.cc
diff --git a/android_webview/renderer/aw_render_view_ext.cc b/android_webview/renderer/aw_render_view_ext.cc
index eaec17844e3dbb6c04f649d71a41de5da38e115c..c14f14e1c9a7c68f006597484655657a8b335825 100644
--- a/android_webview/renderer/aw_render_view_ext.cc
+++ b/android_webview/renderer/aw_render_view_ext.cc
@@ -7,7 +7,6 @@
#include "content/public/renderer/render_frame.h"
#include "content/public/renderer/render_view.h"
#include "third_party/WebKit/public/web/WebFrame.h"
-#include "third_party/WebKit/public/web/WebImageCache.h"
#include "third_party/WebKit/public/web/WebView.h"
namespace android_webview {
@@ -66,15 +65,4 @@ void AwRenderViewExt::CheckContentsSize() {
contents_size));
}
-void AwRenderViewExt::Navigate(const GURL& url) {
- // Navigate is called only on NEW navigations, so WebImageCache won't be
- // freed when the user just clicks on links, but only when a navigation is
- // started, for instance via loadUrl. A better approach would be clearing the
- // cache on cross-site boundaries, however this would require too many
- // changes both on the browser side (in RenderViewHostManger), to the
- // IPCmessages and to the RenderViewObserver. Thus, clearing decoding image
- // cache on Navigate, seems a more acceptable compromise.
- blink::WebImageCache::clear();
-}
-
} // namespace android_webview
« no previous file with comments | « android_webview/renderer/aw_render_view_ext.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698