Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Side by Side Diff: android_webview/renderer/aw_render_view_ext.cc

Issue 1785493002: Move cache clearing from AwRenderViewExt to AwRenderFrameExt. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comment Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « android_webview/renderer/aw_render_view_ext.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "android_webview/renderer/aw_render_view_ext.h" 5 #include "android_webview/renderer/aw_render_view_ext.h"
6 #include "android_webview/common/render_view_messages.h" 6 #include "android_webview/common/render_view_messages.h"
7 #include "content/public/renderer/render_frame.h" 7 #include "content/public/renderer/render_frame.h"
8 #include "content/public/renderer/render_view.h" 8 #include "content/public/renderer/render_view.h"
9 #include "third_party/WebKit/public/web/WebFrame.h" 9 #include "third_party/WebKit/public/web/WebFrame.h"
10 #include "third_party/WebKit/public/web/WebImageCache.h"
11 #include "third_party/WebKit/public/web/WebView.h" 10 #include "third_party/WebKit/public/web/WebView.h"
12 11
13 namespace android_webview { 12 namespace android_webview {
14 13
15 AwRenderViewExt::AwRenderViewExt(content::RenderView* render_view) 14 AwRenderViewExt::AwRenderViewExt(content::RenderView* render_view)
16 : content::RenderViewObserver(render_view) {} 15 : content::RenderViewObserver(render_view) {}
17 16
18 AwRenderViewExt::~AwRenderViewExt() {} 17 AwRenderViewExt::~AwRenderViewExt() {}
19 18
20 // static 19 // static
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 if (contents_size == last_sent_contents_size_) 58 if (contents_size == last_sent_contents_size_)
60 return; 59 return;
61 60
62 last_sent_contents_size_ = contents_size; 61 last_sent_contents_size_ = contents_size;
63 render_view()->GetMainRenderFrame()->Send( 62 render_view()->GetMainRenderFrame()->Send(
64 new AwViewHostMsg_OnContentsSizeChanged( 63 new AwViewHostMsg_OnContentsSizeChanged(
65 render_view()->GetMainRenderFrame()->GetRoutingID(), 64 render_view()->GetMainRenderFrame()->GetRoutingID(),
66 contents_size)); 65 contents_size));
67 } 66 }
68 67
69 void AwRenderViewExt::Navigate(const GURL& url) {
70 // Navigate is called only on NEW navigations, so WebImageCache won't be
71 // freed when the user just clicks on links, but only when a navigation is
72 // started, for instance via loadUrl. A better approach would be clearing the
73 // cache on cross-site boundaries, however this would require too many
74 // changes both on the browser side (in RenderViewHostManger), to the
75 // IPCmessages and to the RenderViewObserver. Thus, clearing decoding image
76 // cache on Navigate, seems a more acceptable compromise.
77 blink::WebImageCache::clear();
78 }
79
80 } // namespace android_webview 68 } // namespace android_webview
OLDNEW
« no previous file with comments | « android_webview/renderer/aw_render_view_ext.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698