Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 1785483002: Handle UNPACK_SKIP_* and PACK_SKIP_* parameters on the client side. (Closed)

Created:
4 years, 9 months ago by Zhenyao Mo
Modified:
4 years, 9 months ago
Reviewers:
piman
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Handle UNPACK_SKIP_* and PACK_SKIP_* parameters on the client side. This is part of https://codereview.chromium.org/1750123002/ Land this separately because this might have an unexpected perf impact (see crbug.com/571885) BUG=487841, 429053 TEST=gpu_unittests,webgl_conformance,webgl2_conformance TBR=piman@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel Committed: https://crrev.com/ccd0b34d80f0e51ac7f5d2b2283934d71b7e488d Cr-Commit-Position: refs/heads/master@{#380260}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -146 lines) Patch
M gpu/command_buffer/client/gles2_implementation.cc View 9 chunks +83 lines, -22 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest.cc View 3 chunks +66 lines, -52 lines 0 comments Download
M gpu/command_buffer/service/context_state.cc View 2 chunks +5 lines, -11 lines 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/feature_info_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 4 chunks +9 lines, -28 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_context_state.cc View 3 chunks +6 lines, -18 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1785483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1785483002/1
4 years, 9 months ago (2016-03-09 21:43:55 UTC) #3
Zhenyao Mo
piman: this is part of the reviewed CL https://codereview.chromium.org/1750123002/ I try to pin-point which change ...
4 years, 9 months ago (2016-03-09 21:51:45 UTC) #4
Zhenyao Mo
On 2016/03/09 21:51:45, Zhenyao Mo wrote: > piman: this is part of the reviewed CL ...
4 years, 9 months ago (2016-03-09 21:52:44 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-09 23:28:48 UTC) #8
Zhenyao Mo
On 2016/03/09 23:28:48, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 9 months ago (2016-03-09 23:33:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1785483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1785483002/1
4 years, 9 months ago (2016-03-09 23:34:29 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-09 23:47:50 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 23:48:46 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ccd0b34d80f0e51ac7f5d2b2283934d71b7e488d
Cr-Commit-Position: refs/heads/master@{#380260}

Powered by Google App Engine
This is Rietveld 408576698