Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Side by Side Diff: gpu/command_buffer/service/feature_info.cc

Issue 1785483002: Handle UNPACK_SKIP_* and PACK_SKIP_* parameters on the client side. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "gpu/command_buffer/service/feature_info.h" 5 #include "gpu/command_buffer/service/feature_info.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <set> 9 #include <set>
10 #include <vector> 10 #include <vector>
(...skipping 371 matching lines...) Expand 10 before | Expand all | Expand 10 after
382 AddExtensionString("GL_CHROMIUM_resize"); 382 AddExtensionString("GL_CHROMIUM_resize");
383 AddExtensionString("GL_CHROMIUM_resource_safe"); 383 AddExtensionString("GL_CHROMIUM_resource_safe");
384 AddExtensionString("GL_CHROMIUM_strict_attribs"); 384 AddExtensionString("GL_CHROMIUM_strict_attribs");
385 AddExtensionString("GL_CHROMIUM_texture_mailbox"); 385 AddExtensionString("GL_CHROMIUM_texture_mailbox");
386 AddExtensionString("GL_CHROMIUM_trace_marker"); 386 AddExtensionString("GL_CHROMIUM_trace_marker");
387 AddExtensionString("GL_EXT_debug_marker"); 387 AddExtensionString("GL_EXT_debug_marker");
388 388
389 // Pre es3, there are no PBOS and all unpack state is handled in client side. 389 // Pre es3, there are no PBOS and all unpack state is handled in client side.
390 // With es3, unpack state is needed in server side. We always mark these 390 // With es3, unpack state is needed in server side. We always mark these
391 // enums as valid and pass them to drivers only when a valid PBO is bound. 391 // enums as valid and pass them to drivers only when a valid PBO is bound.
392 // UNPACK_ROW_LENGTH, UNPACK_SKIP_ROWS, and UNPACK_SKIP_PIXELS are enabled,
393 // but there is no need to add them to pixel_store validtor.
392 AddExtensionString("GL_EXT_unpack_subimage"); 394 AddExtensionString("GL_EXT_unpack_subimage");
393 validators_.pixel_store.AddValue(GL_UNPACK_ROW_LENGTH);
394 validators_.pixel_store.AddValue(GL_UNPACK_SKIP_ROWS);
395 validators_.pixel_store.AddValue(GL_UNPACK_SKIP_PIXELS);
396 395
397 if (feature_flags_.enable_subscribe_uniform) { 396 if (feature_flags_.enable_subscribe_uniform) {
398 AddExtensionString("GL_CHROMIUM_subscribe_uniform"); 397 AddExtensionString("GL_CHROMIUM_subscribe_uniform");
399 } 398 }
400 399
401 // OES_vertex_array_object is emulated if not present natively, 400 // OES_vertex_array_object is emulated if not present natively,
402 // so the extension string is always exposed. 401 // so the extension string is always exposed.
403 AddExtensionString("GL_OES_vertex_array_object"); 402 AddExtensionString("GL_OES_vertex_array_object");
404 403
405 if (!disallowed_features_.gpu_memory_manager) 404 if (!disallowed_features_.gpu_memory_manager)
(...skipping 1029 matching lines...) Expand 10 before | Expand all | Expand 10 after
1435 if (pos == std::string::npos) { 1434 if (pos == std::string::npos) {
1436 extensions_ += (extensions_.empty() ? "" : " ") + str; 1435 extensions_ += (extensions_.empty() ? "" : " ") + str;
1437 } 1436 }
1438 } 1437 }
1439 1438
1440 FeatureInfo::~FeatureInfo() { 1439 FeatureInfo::~FeatureInfo() {
1441 } 1440 }
1442 1441
1443 } // namespace gles2 1442 } // namespace gles2
1444 } // namespace gpu 1443 } // namespace gpu
OLDNEW
« no previous file with comments | « gpu/command_buffer/service/context_state.cc ('k') | gpu/command_buffer/service/feature_info_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698