Handle UNPACK_SKIP_* and PACK_SKIP_* parameters on the client side.

gpu/command_buffer/service/context_state.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/context_state.h"
 
 #include <stddef.h>
 
 #include <cmath>
 
@@ skipping 443 matching lines @@
     glPixelStorei(GL_PACK_ROW_LENGTH, 0);
   }
 }
 
 void ContextState::UpdateUnpackParameters() const {
   if (!feature_info_->IsES3Capable())
     return;
   if (bound_pixel_unpack_buffer.get()) {
     glPixelStorei(GL_UNPACK_ROW_LENGTH, unpack_row_length);
     glPixelStorei(GL_UNPACK_IMAGE_HEIGHT, unpack_image_height);
-    glPixelStorei(GL_UNPACK_SKIP_PIXELS, unpack_skip_pixels);
-    glPixelStorei(GL_UNPACK_SKIP_ROWS, unpack_skip_rows);
-    glPixelStorei(GL_UNPACK_SKIP_IMAGES, unpack_skip_images);
   } else {
     glPixelStorei(GL_UNPACK_ROW_LENGTH, 0);
     glPixelStorei(GL_UNPACK_IMAGE_HEIGHT, 0);
-    glPixelStorei(GL_UNPACK_SKIP_PIXELS, 0);
-    glPixelStorei(GL_UNPACK_SKIP_ROWS, 0);
-    glPixelStorei(GL_UNPACK_SKIP_IMAGES, 0);
   }
 }
 
 void ContextState::SetBoundBuffer(GLenum target, Buffer* buffer) {
   switch (target) {
     case GL_ARRAY_BUFFER:
       bound_array_buffer = buffer;
       break;
     case GL_ELEMENT_ARRAY_BUFFER:
       vertex_attrib_manager->SetElementArrayBuffer(buffer);
@@ skipping 109 matching lines @@
 void ContextState::UnbindSampler(Sampler* sampler) {
   for (size_t jj = 0; jj < sampler_units.size(); ++jj) {
     if (sampler_units[jj].get() == sampler) {
       sampler_units[jj] = nullptr;
       glBindSampler(jj, 0);
     }
   }
 }
 
 PixelStoreParams ContextState::GetPackParams() {
+  DCHECK_EQ(0, pack_skip_pixels);
+  DCHECK_EQ(0, pack_skip_rows);
   PixelStoreParams params;
   params.alignment = pack_alignment;
   params.row_length = pack_row_length;
-  params.skip_pixels = pack_skip_pixels;
-  params.skip_rows = pack_skip_rows;
   return params;
 }
 
 PixelStoreParams ContextState::GetUnpackParams(Dimension dimension) {
+  DCHECK_EQ(0, unpack_skip_pixels);
+  DCHECK_EQ(0, unpack_skip_rows);
+  DCHECK_EQ(0, unpack_skip_images);
   PixelStoreParams params;
   params.alignment = unpack_alignment;
   params.row_length = unpack_row_length;
-  params.skip_pixels = unpack_skip_pixels;
-  params.skip_rows = unpack_skip_rows;
   if (dimension == k3D) {
     params.image_height = unpack_image_height;
-    params.skip_images = unpack_skip_images;
   }
   return params;
 }
 
 void ContextState::InitStateManual(const ContextState*) const {
   // Here we always reset the states whether it's different from previous ones.
   // We have very limited states here; also, once we switch to MANGLE, MANGLE
   // will opmitize this.
   UpdatePackParameters();
   UpdateUnpackParameters();
 }
 
 // Include the auto-generated part of this file. We split this because it means
 // we can easily edit the non-auto generated parts right here in this file
 // instead of having to edit some template or the code generator.
 #include "gpu/command_buffer/service/context_state_impl_autogen.h"
 
 }  // namespace gles2
 }  // namespace gpu