Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1785443002: depot_tools: adjust for resource API changes in recipe engine (Closed)

Created:
4 years, 9 months ago by Paweł Hajdan Jr.
Modified:
4 years, 9 months ago
Reviewers:
iannucci
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

depot_tools: adjust for resource API changes in recipe engine This is rolling in https://codereview.chromium.org/1777003003 BUG=593420 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299187

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -92 lines) Patch
M infra/config/recipes.cfg View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/api.py View 1 chunk +1 line, -1 line 1 comment Download
M recipe_modules/bot_update/example.expected/basic.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/basic_output_manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/basic_with_branch_heads.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/clobber.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/forced.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/no_shallow.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/off.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/reset_root_solution_revision.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/svn_mode.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/trychange.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/trychange_oauth2.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob_fail.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob_fail_patch.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob_fail_patch_download.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob_v8.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/depot_tools/api.py View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/gclient/api.py View 1 chunk +2 lines, -2 lines 0 comments Download
M recipe_modules/gclient/example.expected/basic.json View 11 chunks +14 lines, -14 lines 0 comments Download
M recipe_modules/gclient/example.expected/revision.json View 11 chunks +14 lines, -14 lines 0 comments Download
M recipe_modules/gclient/example.expected/tryserver.json View 11 chunks +14 lines, -14 lines 0 comments Download
M recipe_modules/git/api.py View 3 chunks +5 lines, -4 lines 0 comments Download
M recipe_modules/git/example.expected/platform_win.json View 16 chunks +18 lines, -18 lines 0 comments Download
M recipe_modules/presubmit/api.py View 1 chunk +2 lines, -2 lines 0 comments Download
M recipe_modules/presubmit/example.expected/basic.json View 1 chunk +2 lines, -2 lines 0 comments Download
M recipe_modules/tryserver/example.expected/with_wrong_patch.json View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Paweł Hajdan Jr.
4 years, 9 months ago (2016-03-09 20:43:19 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1785443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1785443002/1
4 years, 9 months ago (2016-03-09 20:43:37 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-09 20:46:08 UTC) #6
iannucci
lgtm https://codereview.chromium.org/1785443002/diff/1/recipe_modules/bot_update/api.py File recipe_modules/bot_update/api.py (left): https://codereview.chromium.org/1785443002/diff/1/recipe_modules/bot_update/api.py#oldcode63 recipe_modules/bot_update/api.py:63: kwargs['env']['PATH'], str(self._module.PACKAGE_DIRECTORY)]) looks like we were already leaking ...
4 years, 9 months ago (2016-03-09 20:48:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1785443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1785443002/1
4 years, 9 months ago (2016-03-09 21:03:09 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 21:05:34 UTC) #11
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299187

Powered by Google App Engine
This is Rietveld 408576698