Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1777003003: recipe_engine: change resource API to use repo root (Closed)

Created:
4 years, 9 months ago by Paweł Hajdan Jr.
Modified:
4 years, 9 months ago
Reviewers:
iannucci, martiniss
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Base URL:
https://github.com/luci/recipes-py.git@master
Target Ref:
refs/heads/master
Project:
recipes-py
Visibility:
Public.

Description

recipe_engine: change resource API to use repo root This makes it possible to use package_repo_resource to get any resource from the package repo, not just ones from the parent directory of recipe directories. BUG=593420 Committed: https://github.com/luci/recipes-py/commit/b8903bd90521b8e3ed14b875dc9b8779263fc37c

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixes #

Patch Set 3 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -24 lines) Patch
M recipe_engine/config_types.py View 1 chunk +3 lines, -2 lines 0 comments Download
M recipe_engine/loader.py View 2 chunks +2 lines, -2 lines 0 comments Download
M recipe_engine/package.py View 1 2 chunks +3 lines, -1 line 0 comments Download
M recipe_engine/recipe_api.py View 1 chunk +3 lines, -3 lines 0 comments Download
M recipe_modules/path/api.py View 1 chunk +2 lines, -2 lines 0 comments Download
M recipe_modules/path/example.py View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M recipe_modules/path/example.expected/linux.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/path/example.expected/linux_kitchen.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/path/example.expected/linux_swarming.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/path/example.expected/mac.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/path/example.expected/win.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/step/example.py View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/step/example.expected/basic.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/step/example.expected/defer_results.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/step/example.expected/exceptional.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/step/example.expected/infra_failure.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/step/example.expected/invalid_access.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/step/example.expected/warning.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (8 generated)
Paweł Hajdan Jr.
4 years, 9 months ago (2016-03-09 20:15:08 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1777003003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1777003003/1
4 years, 9 months ago (2016-03-09 20:15:18 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Recipes-py Presubmit on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Recipes-py%20Presubmit/builds/94)
4 years, 9 months ago (2016-03-09 20:18:29 UTC) #6
iannucci
+martiniss https://codereview.chromium.org/1777003003/diff/1/recipe_modules/path/example.py File recipe_modules/path/example.py (right): https://codereview.chromium.org/1777003003/diff/1/recipe_modules/path/example.py#newcode23 recipe_modules/path/example.py:23: # module.package_dir() demo. package_repo_resource ?
4 years, 9 months ago (2016-03-09 20:23:30 UTC) #8
Paweł Hajdan Jr.
PTAL https://codereview.chromium.org/1777003003/diff/1/recipe_modules/path/example.py File recipe_modules/path/example.py (right): https://codereview.chromium.org/1777003003/diff/1/recipe_modules/path/example.py#newcode23 recipe_modules/path/example.py:23: # module.package_dir() demo. On 2016/03/09 at 20:23:30, iannucci ...
4 years, 9 months ago (2016-03-09 20:26:16 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1777003003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1777003003/40001
4 years, 9 months ago (2016-03-09 20:26:28 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-09 20:27:59 UTC) #13
iannucci
This lgtm. The API rename should prevent the autoroller from mistakenly applying this downstream without ...
4 years, 9 months ago (2016-03-09 20:34:54 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1777003003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1777003003/40001
4 years, 9 months ago (2016-03-09 20:38:26 UTC) #16
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 20:40:06 UTC) #18
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://github.com/luci/recipes-py/commit/b8903bd90521b8e3ed14b875dc9b8779263...

Powered by Google App Engine
This is Rietveld 408576698