recipe_modules/presubmit/api.py - Issue 1785443002: depot_tools: adjust for resource API changes in recipe engine

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: recipe_modules/presubmit/api.py

Issue 1785443002: depot_tools: adjust for resource API changes in recipe engine (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright 2016 The Chromium Authors. All rights reserved.	1 # Copyright 2016 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 from recipe_engine import recipe_api	5 from recipe_engine import recipe_api

6	6

7 class PresubmitApi(recipe_api.RecipeApi):	7 class PresubmitApi(recipe_api.RecipeApi):

8 def __call__(self, args, *kwargs):	8 def __call__(self, args, *kwargs):

9 """Return a presubmit step."""	9 """Return a presubmit step."""

10	10

11 name = kwargs.pop('name', 'presubmit')	11 name = kwargs.pop('name', 'presubmit')

12	12

13 kwargs.setdefault('env', {})	13 kwargs.setdefault('env', {})

14 kwargs['env'].setdefault('PATH', '%(PATH)s')	14 kwargs['env'].setdefault('PATH', '%(PATH)s')

15 kwargs['env']['PATH'] = self.m.path.pathsep.join([	15 kwargs['env']['PATH'] = self.m.path.pathsep.join([

16 kwargs['env']['PATH'], str(self._module.PACKAGE_DIRECTORY)])	16 kwargs['env']['PATH'], str(self._module.PACKAGE_REPO_ROOT)])

17	17

18 return self.m.python(	18 return self.m.python(

19 name, self.package_resource('presubmit_support.py'), list(args),	19 name, self.package_repo_resource('presubmit_support.py'), list(args),

20 **kwargs)	20 **kwargs)

OLD	NEW