Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1785253003: [deoptimizer] Removed asserts that do not hold in case of tail call elimination. (Closed)

Created:
4 years, 9 months ago by Igor Sheludko
Modified:
4 years, 9 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@cr593697-2
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[deoptimizer] Removed asserts that do not hold in case of tail call elimination. These checks can fail if there bottommost function is a tail caller and the next function has different number of arguments than the bottommost one. BUG=chromium:593697, v8:4698 LOG=N Committed: https://crrev.com/dd0e6ca04c14a5ff9fe26569255f98cebe6125fe Cr-Commit-Position: refs/heads/master@{#34718}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M src/deoptimizer.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1785253003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1785253003/1
4 years, 9 months ago (2016-03-11 11:50:51 UTC) #2
Igor Sheludko
PTAL
4 years, 9 months ago (2016-03-11 11:51:05 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-11 12:12:52 UTC) #7
Jarin
lgtm
4 years, 9 months ago (2016-03-11 12:30:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1785253003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1785253003/1
4 years, 9 months ago (2016-03-11 12:31:11 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-11 12:32:49 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 12:33:01 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dd0e6ca04c14a5ff9fe26569255f98cebe6125fe
Cr-Commit-Position: refs/heads/master@{#34718}

Powered by Google App Engine
This is Rietveld 408576698