src/deoptimizer.cc - Issue 1785253003: [deoptimizer] Removed asserts that do not hold in case of tail call elimination.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/deoptimizer.cc

Issue 1785253003: [deoptimizer] Removed asserts that do not hold in case of tail call elimination. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@cr593697-2

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/deoptimizer.cc

diff --git a/src/deoptimizer.cc b/src/deoptimizer.cc

index e38172f1527135f674fa39411d416efb65f20926..de57bf33e529f75dc964faf9053fe3ce60d8f701 100644

--- a/src/deoptimizer.cc

+++ b/src/deoptimizer.cc

@@ -944,7 +944,6 @@ void Deoptimizer::DoComputeJSFrame(TranslatedFrame* translated_frame,

}

output_frame->SetCallerFp(output_offset, value);

intptr_t fp_value = top_address + output_offset;

- DCHECK(!is_bottommost || stack_fp_ == fp_value);

output_frame->SetFp(fp_value);

if (is_topmost) output_frame->SetRegister(fp_reg.code(), fp_value);

DebugPrintOutputSlot(value, frame_index, output_offset, "caller's fp\n");

@@ -1168,7 +1167,6 @@ void Deoptimizer::DoComputeInterpretedFrame(TranslatedFrame* translated_frame,

}