Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2631)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1781303002: [turbofan] Avoid dereferencing empty handle when inlining a tail call. (Closed)

Created:
4 years, 9 months ago by Igor Sheludko
Modified:
4 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Avoid dereferencing empty handle when inlining a tail call. BUG=chromium:593697, v8:4698 LOG=N Committed: https://crrev.com/690c7a854a9673ea6459e3da7db9bc0818d5ba82 Cr-Commit-Position: refs/heads/master@{#34716}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -12 lines) Patch
M src/compiler/js-inlining.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-593697-2.js View 1 chunk +11 lines, -8 lines 0 comments Download

Dependent Patchsets:

Issue 1785253003 Patch 1

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1781303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1781303002/1
4 years, 9 months ago (2016-03-11 11:19:15 UTC) #2
Igor Sheludko
PTAL
4 years, 9 months ago (2016-03-11 11:33:54 UTC) #4
Michael Starzinger
LGTM.
4 years, 9 months ago (2016-03-11 11:36:38 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-11 11:38:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1781303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1781303002/1
4 years, 9 months ago (2016-03-11 11:38:41 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-11 11:40:22 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 11:41:36 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/690c7a854a9673ea6459e3da7db9bc0818d5ba82
Cr-Commit-Position: refs/heads/master@{#34716}

Powered by Google App Engine
This is Rietveld 408576698