Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1784743002: Migrate *-ime-thread switches to feature API (Closed)

Created:
4 years, 9 months ago by Changwan Ryu
Modified:
4 years, 9 months ago
Reviewers:
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, asvitkine+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Migrate *-ime-thread switches to feature API The new Feature API is the simplest way to run Finch experiments with. Also, it gets propagated to the renderer. BUG=551193, 591149 Review URL: https://codereview.chromium.org/1771223002 Cr-Commit-Position: refs/heads/master@{#380256} (cherry picked from commit 7ded37535ac881713223cf71d9168887ec60caf3) Committed: https://chromium.googlesource.com/chromium/src/+/9d4eb204f3cdf8f282f258aaf1770d6d3727bb21

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -36 lines) Patch
M chrome/browser/about_flags.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/ime_adapter_android.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/ime_adapter_android.cc View 3 chunks +8 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java View 4 chunks +8 lines, -14 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/common/ContentSwitches.java View 1 chunk +0 lines, -4 lines 0 comments Download
M content/public/common/content_features.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_features.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/renderer/render_widget.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_android.json View 1 chunk +8 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Changwan Ryu
4 years, 9 months ago (2016-03-10 01:58:03 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
9d4eb204f3cdf8f282f258aaf1770d6d3727bb21.

Powered by Google App Engine
This is Rietveld 408576698