Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 1784743002: Migrate *-ime-thread switches to feature API (Closed) Base URL: https://chromium.googlesource.com/a/chromium/src.git@2661
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/browser/renderer_host/ime_adapter_android.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 1800 matching lines...) Expand 10 before | Expand all | Expand 10 after
1811 SINGLE_VALUE_TYPE(extensions::switches::kEnableTabForDesktopShare)} 1811 SINGLE_VALUE_TYPE(extensions::switches::kEnableTabForDesktopShare)}
1812 #endif 1812 #endif
1813 #if defined(OS_ANDROID) 1813 #if defined(OS_ANDROID)
1814 {"enable-ntp-snippets", IDS_FLAGS_ENABLE_NTP_SNIPPETS_NAME, 1814 {"enable-ntp-snippets", IDS_FLAGS_ENABLE_NTP_SNIPPETS_NAME,
1815 IDS_FLAGS_ENABLE_NTP_SNIPPETS_DESCRIPTION, kOsAndroid, 1815 IDS_FLAGS_ENABLE_NTP_SNIPPETS_DESCRIPTION, kOsAndroid,
1816 FEATURE_VALUE_TYPE(chrome::android::kNTPSnippetsFeature)}, 1816 FEATURE_VALUE_TYPE(chrome::android::kNTPSnippetsFeature)},
1817 #endif // defined(OS_ANDROID) 1817 #endif // defined(OS_ANDROID)
1818 #if defined(OS_ANDROID) 1818 #if defined(OS_ANDROID)
1819 {"ime-thread", IDS_FLAGS_IME_THREAD_NAME, 1819 {"ime-thread", IDS_FLAGS_IME_THREAD_NAME,
1820 IDS_FLAGS_IME_THREAD_DESCRIPTION, kOsAndroid, 1820 IDS_FLAGS_IME_THREAD_DESCRIPTION, kOsAndroid,
1821 ENABLE_DISABLE_VALUE_TYPE(switches::kEnableImeThread, 1821 FEATURE_VALUE_TYPE(features::kImeThread)},
1822 switches::kDisableImeThread)},
1823 #endif // defined(OS_ANDROID) 1822 #endif // defined(OS_ANDROID)
1824 #if defined(OS_ANDROID) 1823 #if defined(OS_ANDROID)
1825 {"offline-pages-ntp", IDS_FLAGS_NTP_OFFLINE_PAGES_NAME, 1824 {"offline-pages-ntp", IDS_FLAGS_NTP_OFFLINE_PAGES_NAME,
1826 IDS_FLAGS_NTP_OFFLINE_PAGES_DESCRIPTION, kOsAndroid, 1825 IDS_FLAGS_NTP_OFFLINE_PAGES_DESCRIPTION, kOsAndroid,
1827 FEATURE_VALUE_TYPE(chrome::android::kNTPOfflinePagesFeature)}, 1826 FEATURE_VALUE_TYPE(chrome::android::kNTPOfflinePagesFeature)},
1828 #endif // defined(OS_ANDROID) 1827 #endif // defined(OS_ANDROID)
1829 // NOTE: Adding new command-line switches requires adding corresponding 1828 // NOTE: Adding new command-line switches requires adding corresponding
1830 // entries to enum "LoginCustomFlags" in histograms.xml. See note in 1829 // entries to enum "LoginCustomFlags" in histograms.xml. See note in
1831 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test. 1830 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.
1832 }; 1831 };
(...skipping 207 matching lines...) Expand 10 before | Expand all | Expand 10 after
2040 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2039 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2041 2040
2042 const FeatureEntry* GetFeatureEntries(size_t* count) { 2041 const FeatureEntry* GetFeatureEntries(size_t* count) {
2043 *count = arraysize(kFeatureEntries); 2042 *count = arraysize(kFeatureEntries);
2044 return kFeatureEntries; 2043 return kFeatureEntries;
2045 } 2044 }
2046 2045
2047 } // namespace testing 2046 } // namespace testing
2048 2047
2049 } // namespace about_flags 2048 } // namespace about_flags
OLDNEW
« no previous file with comments | « no previous file | content/browser/renderer_host/ime_adapter_android.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698