Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1771223002: Migrate *-ime-thread switches to feature API (Closed)

Created:
4 years, 9 months ago by Changwan Ryu
Modified:
4 years, 9 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, asvitkine+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate *-ime-thread switches to feature API The new Feature API is the simplest way to run Finch experiments with. Also, it gets propagated to the renderer. BUG=551193, 591149 Committed: https://crrev.com/7ded37535ac881713223cf71d9168887ec60caf3 Cr-Commit-Position: refs/heads/master@{#380256}

Patch Set 1 #

Patch Set 2 : #

Total comments: 8

Patch Set 3 : plumb imeadapter instead and fixed nits #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -36 lines) Patch
M chrome/browser/about_flags.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/ime_adapter_android.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/ime_adapter_android.cc View 1 2 3 chunks +8 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java View 1 2 4 chunks +8 lines, -14 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/common/ContentSwitches.java View 1 chunk +0 lines, -4 lines 0 comments Download
M content/public/common/content_features.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_features.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/renderer/render_widget.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_android.json View 1 chunk +8 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 chunks +0 lines, -2 lines 2 comments Download

Messages

Total messages: 19 (7 generated)
Changwan Ryu
PTAL
4 years, 9 months ago (2016-03-08 03:47:18 UTC) #3
Ted C
lgtm https://codereview.chromium.org/1771223002/diff/20001/content/public/common/content_features.cc File content/public/common/content_features.cc (right): https://codereview.chromium.org/1771223002/diff/20001/content/public/common/content_features.cc#newcode32 content/public/common/content_features.cc:32: // Use IME's own thread instead of using ...
4 years, 9 months ago (2016-03-08 21:49:43 UTC) #4
no sievers
https://codereview.chromium.org/1771223002/diff/20001/content/browser/android/content_feature_list.cc File content/browser/android/content_feature_list.cc (right): https://codereview.chromium.org/1771223002/diff/20001/content/browser/android/content_feature_list.cc#newcode14 content/browser/android/content_feature_list.cc:14: #include "content/public/common/content_features.h" This file and the Java class seem ...
4 years, 9 months ago (2016-03-08 22:08:24 UTC) #5
Changwan Ryu
https://codereview.chromium.org/1771223002/diff/20001/content/browser/android/content_feature_list.cc File content/browser/android/content_feature_list.cc (right): https://codereview.chromium.org/1771223002/diff/20001/content/browser/android/content_feature_list.cc#newcode14 content/browser/android/content_feature_list.cc:14: #include "content/public/common/content_features.h" On 2016/03/08 22:08:23, sievers wrote: > This ...
4 years, 9 months ago (2016-03-09 01:43:56 UTC) #6
Changwan Ryu
rkaplow@, could you take a look at tools/metrics/ and testing/variations/?
4 years, 9 months ago (2016-03-09 02:03:17 UTC) #8
no sievers
lgtm
4 years, 9 months ago (2016-03-09 18:56:57 UTC) #9
rkaplow
lgtm
4 years, 9 months ago (2016-03-09 22:17:04 UTC) #10
rkaplow
lgtm https://codereview.chromium.org/1771223002/diff/40001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/1771223002/diff/40001/tools/metrics/histograms/histograms.xml#oldcode72153 tools/metrics/histograms/histograms.xml:72153: - <int value="-1919308574" label="enable-ime-thread"/> would prefer to leave ...
4 years, 9 months ago (2016-03-09 22:22:41 UTC) #11
Changwan Ryu
https://codereview.chromium.org/1771223002/diff/40001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/1771223002/diff/40001/tools/metrics/histograms/histograms.xml#oldcode72153 tools/metrics/histograms/histograms.xml:72153: - <int value="-1919308574" label="enable-ime-thread"/> On 2016/03/09 22:22:41, rkaplow wrote: ...
4 years, 9 months ago (2016-03-09 23:16:02 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1771223002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1771223002/40001
4 years, 9 months ago (2016-03-09 23:16:49 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-09 23:25:21 UTC) #17
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 23:28:50 UTC) #19
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/7ded37535ac881713223cf71d9168887ec60caf3
Cr-Commit-Position: refs/heads/master@{#380256}

Powered by Google App Engine
This is Rietveld 408576698