[Extensions UI Cocoa] Make disabled actions respond to the keyboard
There was a bug where an otherwise-disabled action wouldn't respond to key
presses. Fix this, and add a test.
BUG=592825
Committed: https://crrev.com/98f7b6d97ccaa3c469319a0e1bbc051885847d0b
Cr-Commit-Position: refs/heads/master@{#380659}
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1784533003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1784533003/40001
4 years, 9 months ago
(2016-03-10 23:10:34 UTC)
#8
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/193524)
4 years, 9 months ago
(2016-03-10 23:45:31 UTC)
#10
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1784533003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1784533003/40001
4 years, 9 months ago
(2016-03-10 23:48:54 UTC)
#12
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/129133) linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 9 months ago
(2016-03-11 00:21:08 UTC)
#14
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1784533003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1784533003/40001
4 years, 9 months ago
(2016-03-11 01:32:46 UTC)
#16
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/138305)
4 years, 9 months ago
(2016-03-11 02:03:09 UTC)
#18
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1784533003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1784533003/40001
4 years, 9 months ago
(2016-03-11 16:20:55 UTC)
#20
4 years, 9 months ago
(2016-03-11 17:21:16 UTC)
#21
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
commit-bot: I haz the power
Description was changed from ========== [Extensions UI Cocoa] Make disabled actions respond to the keyboard ...
4 years, 9 months ago
(2016-03-11 17:23:06 UTC)
#22
Message was sent while issue was closed.
Description was changed from
==========
[Extensions UI Cocoa] Make disabled actions respond to the keyboard
There was a bug where an otherwise-disabled action wouldn't respond to key
presses. Fix this, and add a test.
BUG=592825
==========
to
==========
[Extensions UI Cocoa] Make disabled actions respond to the keyboard
There was a bug where an otherwise-disabled action wouldn't respond to key
presses. Fix this, and add a test.
BUG=592825
Committed: https://crrev.com/98f7b6d97ccaa3c469319a0e1bbc051885847d0b
Cr-Commit-Position: refs/heads/master@{#380659}
==========
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/98f7b6d97ccaa3c469319a0e1bbc051885847d0b Cr-Commit-Position: refs/heads/master@{#380659}
4 years, 9 months ago
(2016-03-11 17:23:07 UTC)
#23
Issue 1784533003: [Extensions UI Cocoa] Make disabled actions respond to the keyboard
(Closed)
Created 4 years, 9 months ago by Devlin
Modified 4 years, 9 months ago
Reviewers: Finnur, Avi (use Gerrit)
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Comments: 0