chrome/browser/ui/extensions/extension_action_view_controller.cc - Issue 1784533003: [Extensions UI Cocoa] Make disabled actions respond to the keyboard

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/extensions/extension_action_view_controller.cc

Issue 1784533003: [Extensions UI Cocoa] Make disabled actions respond to the keyboard (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Linux compile fix Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/extensions/extension_action_platform_delegate.h ('k') | chrome/browser/ui/views/extensions/extension_action_platform_delegate_views.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/extensions/extension_action_view_controller.cc

diff --git a/chrome/browser/ui/extensions/extension_action_view_controller.cc b/chrome/browser/ui/extensions/extension_action_view_controller.cc

index ee58e3b0b9cdff30eb1cdf16db1684642155b500..06a8ec02c0007ef70458a8b32cf1249e6f649073 100644

--- a/chrome/browser/ui/extensions/extension_action_view_controller.cc

+++ b/chrome/browser/ui/extensions/extension_action_view_controller.cc

@@ -184,6 +184,15 @@ void ExtensionActionViewController::OnContextMenuClosed() {

}

bool ExtensionActionViewController::ExecuteAction(bool by_user) {

+ if (!ExtensionIsValid())

+ return false;

+ if (!IsEnabled(view_delegate_->GetCurrentWebContents())) {

+ if (DisabledClickOpensMenu())

+ GetPreferredPopupViewController()->platform_delegate_->ShowContextMenu();

+ return false;

+ }

return ExecuteAction(SHOW_POPUP, by_user);

}