Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.mm

Issue 1784533003: [Extensions UI Cocoa] Make disabled actions respond to the keyboard (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Linux compile fix Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.mm
diff --git a/chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.mm b/chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.mm
index db8a936d128f3f59c343b51fdb6f80c0d80a5ca2..11178a55566436638e111e855bd7f4d6a027bf67 100644
--- a/chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.mm
+++ b/chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.mm
@@ -14,6 +14,7 @@
#include "chrome/browser/ui/browser_window.h"
#import "chrome/browser/ui/cocoa/app_menu/app_menu_controller.h"
#import "chrome/browser/ui/cocoa/browser_window_controller.h"
+#import "chrome/browser/ui/cocoa/extensions/browser_action_button.h"
#import "chrome/browser/ui/cocoa/extensions/browser_actions_controller.h"
#import "chrome/browser/ui/cocoa/extensions/extension_popup_controller.h"
#import "chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h"
@@ -92,6 +93,20 @@ void ExtensionActionPlatformDelegateCocoa::CloseOverflowMenu() {
[appMenuController cancel];
}
+void ExtensionActionPlatformDelegateCocoa::ShowContextMenu() {
+ // We should only use this code path for extensions shown in the toolbar.
+ DCHECK(controller_->extension_action()->action_type() ==
+ extensions::ActionInfo::TYPE_BROWSER ||
+ extensions::FeatureSwitch::extension_action_redesign()->IsEnabled());
+ BrowserWindowController* windowController = [BrowserWindowController
+ browserWindowControllerForWindow:controller_->browser()
+ ->window()
+ ->GetNativeWindow()];
+ BrowserActionsController* actionsController =
+ [[windowController toolbarController] browserActionsController];
+ [[actionsController mainButtonForId:controller_->GetId()] showContextMenu];
+}
+
NSPoint ExtensionActionPlatformDelegateCocoa::GetPopupPoint() const {
BrowserWindowController* windowController =
[BrowserWindowController browserWindowControllerForWindow:

Powered by Google App Engine
This is Rietveld 408576698