Subzero: Improve the use of timers.

Subzero: Improve the use of timers.

Several things are done here:

1. Move timer support to be guarded by the ALLOW_TIMERS define, or the BuildDefs::timers() constexpr method.

2. Add a NODUMP build configuration to control whether dump support is built in.  So "make -f Makefile.standalone NODUMP=1 NOASSERT=1" is pretty close to a MINIMAL build with timer support.

3. Add some missing timers: alloca analysis, RMW analysis, helper call pre-lowering, load optimization analysis.  These omitted pass timings were being rolled up into the "O2" bucket.

4. Add timers around push and pop operations on the translate queue and the emit queue.

5. Refactor the clumsy code to push/pop function timers (as opposed to pass timers), so that it fits into the nice RAII TimerMarker class like the pass timers.

6. It turns out that even with MINIMAL or NODUMP builds, we still construct a longish std::string every time Cfg::dump() is called, even though the string isn't used in MINIMAL/NODUMP mode.  The dump() arg might as well be a const char * arg instead.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4360
R=kschimpf@google.com

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=b88d8c878538d856b845bd5cabdff7e75ef2761a

[Jim Stichnoth, 2016-03-11 22:46:50]

Description was changed from

==========
Subzero: Improve the use of timers.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4360
==========

to

==========
Subzero: Improve the use of timers.

Several things are done here:

1. Move timer support to be guarded by the ALLOW_TIMERS define, or the
BuildDefs::timers() constexpr method.

2. Add a NODUMP build configuration to control whether dump support is built in.
 So "make -f Makefile.standalone NODUMP=1 NOASSERT=1" is pretty close to a
MINIMAL build with timer support.

3. Add some missing timers: alloca analysis, RMW analysis, helper call
pre-lowering, load optimization analysis.  These pass timings were being rolled
up into the "O2" bucket.

4. Add timers around push and pop operations on the translate queue and the emit
queue.

5. Refactor the clumsy code to push/pop function timers (as opposed to pass
timers), so that it fits into the nice RAII TimerMarker class like the pass
timers.

6. It turns out that even with MINIMAL or NODUMP builds, we still construct a
longish std::string every time Cfg::dump() is called, even though the string
isn't used in MINIMAL/NODUMP mode.  The dump() arg might as well be a const char
* arg instead.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4360
==========

[Jim Stichnoth, 2016-03-11 22:46:50]

stichnot@chromium.org changed reviewers:
+ eholk@chromium.org, jpp@chromium.org, kschimpf@google.com, sehr@chromium.org

[Jim Stichnoth, 2016-03-11 22:48:08]

Description was changed from

==========
Subzero: Improve the use of timers.

Several things are done here:

1. Move timer support to be guarded by the ALLOW_TIMERS define, or the
BuildDefs::timers() constexpr method.

2. Add a NODUMP build configuration to control whether dump support is built in.
 So "make -f Makefile.standalone NODUMP=1 NOASSERT=1" is pretty close to a
MINIMAL build with timer support.

3. Add some missing timers: alloca analysis, RMW analysis, helper call
pre-lowering, load optimization analysis.  These pass timings were being rolled
up into the "O2" bucket.

4. Add timers around push and pop operations on the translate queue and the emit
queue.

5. Refactor the clumsy code to push/pop function timers (as opposed to pass
timers), so that it fits into the nice RAII TimerMarker class like the pass
timers.

6. It turns out that even with MINIMAL or NODUMP builds, we still construct a
longish std::string every time Cfg::dump() is called, even though the string
isn't used in MINIMAL/NODUMP mode.  The dump() arg might as well be a const char
* arg instead.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4360
==========

to

==========
Subzero: Improve the use of timers.

Several things are done here:

1. Move timer support to be guarded by the ALLOW_TIMERS define, or the
BuildDefs::timers() constexpr method.

2. Add a NODUMP build configuration to control whether dump support is built in.
 So "make -f Makefile.standalone NODUMP=1 NOASSERT=1" is pretty close to a
MINIMAL build with timer support.

3. Add some missing timers: alloca analysis, RMW analysis, helper call
pre-lowering, load optimization analysis.  These omitted pass timings were being
rolled up into the "O2" bucket.

4. Add timers around push and pop operations on the translate queue and the emit
queue.

5. Refactor the clumsy code to push/pop function timers (as opposed to pass
timers), so that it fits into the nice RAII TimerMarker class like the pass
timers.

6. It turns out that even with MINIMAL or NODUMP builds, we still construct a
longish std::string every time Cfg::dump() is called, even though the string
isn't used in MINIMAL/NODUMP mode.  The dump() arg might as well be a const char
* arg instead.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4360
==========

[Karl, 2016-03-11 23:05:50]

lgtm

https://codereview.chromium.org/1784243006/diff/1/src/IceCompiler.cpp
File src/IceCompiler.cpp (right):

https://codereview.chromium.org/1784243006/diff/1/src/IceCompiler.cpp#newcode142
src/IceCompiler.cpp:142: constexpr bool NoDumpCumulative = false;
What about?

  constexpr bool DumpCumulative = true;
  Ctx.DumpTimers(..., !DumpCumulative);

https://codereview.chromium.org/1784243006/diff/1/src/PNaClTranslator.cpp
File src/PNaClTranslator.cpp (right):

https://codereview.chromium.org/1784243006/diff/1/src/PNaClTranslator.cpp#new...
src/PNaClTranslator.cpp:1345: getTranslator().getNextSequenceNumber());
Curiosity: Why not include this in the time?

[Jim Stichnoth, 2016-03-11 23:32:34]

https://codereview.chromium.org/1784243006/diff/1/src/IceCompiler.cpp
File src/IceCompiler.cpp (right):

https://codereview.chromium.org/1784243006/diff/1/src/IceCompiler.cpp#newcode142
src/IceCompiler.cpp:142: constexpr bool NoDumpCumulative = false;
On 2016/03/11 23:05:50, Karl wrote:
> What about?
> 
>   constexpr bool DumpCumulative = true;
>   Ctx.DumpTimers(..., !DumpCumulative);

I think we've been converging to the style that I "corrected" this to.  See "git
grep 'bool No'".

https://codereview.chromium.org/1784243006/diff/1/src/PNaClTranslator.cpp
File src/PNaClTranslator.cpp (right):

https://codereview.chromium.org/1784243006/diff/1/src/PNaClTranslator.cpp#new...
src/PNaClTranslator.cpp:1345: getTranslator().getNextSequenceNumber());
On 2016/03/11 23:05:50, Karl wrote:
> Curiosity: Why not include this in the time?

It was because of the scoping - I need the timer to be popped before
translateFcn() is called, because it will push the same timer again.

But now I realize that I can move the create() into the scope, so done.

[Jim Stichnoth, 2016-03-11 23:33:04]

Description was changed from

==========
Subzero: Improve the use of timers.

Several things are done here:

1. Move timer support to be guarded by the ALLOW_TIMERS define, or the
BuildDefs::timers() constexpr method.

2. Add a NODUMP build configuration to control whether dump support is built in.
 So "make -f Makefile.standalone NODUMP=1 NOASSERT=1" is pretty close to a
MINIMAL build with timer support.

3. Add some missing timers: alloca analysis, RMW analysis, helper call
pre-lowering, load optimization analysis.  These omitted pass timings were being
rolled up into the "O2" bucket.

4. Add timers around push and pop operations on the translate queue and the emit
queue.

5. Refactor the clumsy code to push/pop function timers (as opposed to pass
timers), so that it fits into the nice RAII TimerMarker class like the pass
timers.

6. It turns out that even with MINIMAL or NODUMP builds, we still construct a
longish std::string every time Cfg::dump() is called, even though the string
isn't used in MINIMAL/NODUMP mode.  The dump() arg might as well be a const char
* arg instead.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4360
==========

to

==========
Subzero: Improve the use of timers.

Several things are done here:

1. Move timer support to be guarded by the ALLOW_TIMERS define, or the
BuildDefs::timers() constexpr method.

2. Add a NODUMP build configuration to control whether dump support is built in.
 So "make -f Makefile.standalone NODUMP=1 NOASSERT=1" is pretty close to a
MINIMAL build with timer support.

3. Add some missing timers: alloca analysis, RMW analysis, helper call
pre-lowering, load optimization analysis.  These omitted pass timings were being
rolled up into the "O2" bucket.

4. Add timers around push and pop operations on the translate queue and the emit
queue.

5. Refactor the clumsy code to push/pop function timers (as opposed to pass
timers), so that it fits into the nice RAII TimerMarker class like the pass
timers.

6. It turns out that even with MINIMAL or NODUMP builds, we still construct a
longish std::string every time Cfg::dump() is called, even though the string
isn't used in MINIMAL/NODUMP mode.  The dump() arg might as well be a const char
* arg instead.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4360
R=kschimpf@google.com

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Jim Stichnoth, 2016-03-11 23:33:05]

Committed patchset #2 (id:20001) manually as
b88d8c878538d856b845bd5cabdff7e75ef2761a (presubmit successful).