Subzero: Improve the use of timers.

src/IceCompiler.cpp

 //===- subzero/src/IceCompiler.cpp - Driver for bitcode translation -------===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 ///
 /// \file
@@ skipping 121 matching lines @@
       TimerMarker T1(Ice::TimerStack::TT_emitAsm, &Ctx);
       Ctx.getObjectWriter()->setUndefinedSyms(Ctx.getConstantExternSyms());
       Ctx.getObjectWriter()->writeNonUserSections();
     }
   }
 
   if (Ctx.getFlags().getSubzeroTimingEnabled())
     Ctx.dumpTimers();
 
   if (Ctx.getFlags().getTimeEachFunction()) {
-    constexpr bool DumpCumulative = false;
-    Ctx.dumpTimers(GlobalContext::TSK_Funcs, DumpCumulative);
+    constexpr bool NoDumpCumulative = false;

[Karl, 2016/03/11 23:05:50]

What about?

  constexpr bool DumpCumulative = true;
  Ctx.DumpTimers(..., !DumpCumulative);

[Jim Stichnoth, 2016/03/11 23:32:34]

I think we've been converging to the style that I "corrected" this to.  See "git
grep 'bool No'".

+    Ctx.dumpTimers(GlobalContext::TSK_Funcs, NoDumpCumulative);
   }
   constexpr bool FinalStats = true;
   Ctx.dumpStats("_FINAL_", FinalStats);
 }
 
 } // end of namespace Ice