Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 1784023002: Add sampler precision to GrTextureAccess (Closed)

Created:
4 years, 9 months ago by Chris Dalton
Modified:
4 years, 9 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@upload2_verttex
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -16 lines) Patch
M include/gpu/GrTextureAccess.h View 2 chunks +10 lines, -4 lines 0 comments Download
M include/gpu/GrTypesPriv.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/gpu/GrTextureAccess.cpp View 1 chunk +9 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLUniformHandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/glsl/GrGLSLProgramBuilder.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/glsl/GrGLSLShaderVar.h View 6 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Chris Dalton
4 years, 9 months ago (2016-03-11 00:11:24 UTC) #3
bsalomon
lgtm
4 years, 9 months ago (2016-03-11 14:11:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1784023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1784023002/1
4 years, 9 months ago (2016-03-11 18:10:50 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_64-Release-Trybot/builds/1140)
4 years, 9 months ago (2016-03-11 18:12:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1784023002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1784023002/20001
4 years, 9 months ago (2016-03-11 21:24:50 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/5f2d8e28c4f8ec0ead92eb613254063ace4e90b4
4 years, 9 months ago (2016-03-11 21:34:35 UTC) #13
Chris Dalton
4 years, 8 months ago (2016-04-01 20:41:44 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1851173002/ by cdalton@nvidia.com.

The reason for reverting is: Did not account for sampler precision in the
program key..

Powered by Google App Engine
This is Rietveld 408576698