Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 1783803002: Revert of Clang plugin to check that unstable types are not used in IPC. (Closed)

Created:
4 years, 9 months ago by Nico
Modified:
4 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Clang plugin to check that unstable types are not used in IPC. (patchset #22 id:420001 of https://codereview.chromium.org/1665363002/ ) Reason for revert: IPC plugin tests are failing on the clang/tot win bots, even after the fix attempt. Original issue's description: > Clang plugin to check that unstable types are not used in IPC. > > We want IPC messages to be stable so that 32-bit and 64-bit processes > can talk to each other. This plugin blacklists the following types that > are known to be unstable: > > 1. Types: long / unsigned long (but not typedefs to) > 2. Typedefs: intmax_t, uintmax_t, intptr_t, uintptr_t, wint_t, > size_t, rsize_t, ssize_t, ptrdiff_t, dev_t, off_t, clock_t, > time_t, suseconds_t (including typedefs to) > > Blacklisted types are not allowed in IPC::WriteParam() invocations or > IPC::CheckedTuple<> specializations. > > BUG=581409 > CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel > > Committed: https://crrev.com/a817c371a7a33cdf9282b711dafbdcee83b788e4 > Cr-Commit-Position: refs/heads/master@{#380151} TBR=dcheng@chromium.org,jam@chromium.org,vmpstr@chromium.org,hans@chromium.org,dskiba@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=581409 Committed: https://crrev.com/fe36ec4d077c3a89979854bf37328dd41bb24ca6 Cr-Commit-Position: refs/heads/master@{#380408}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1033 lines) Patch
M ipc/ipc_message_macros.h View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_message_utils.h View 1 chunk +0 lines, -14 lines 0 comments Download
M tools/clang/plugins/CMakeLists.txt View 1 chunk +1 line, -2 lines 0 comments Download
D tools/clang/plugins/CheckIPCVisitor.h View 1 chunk +0 lines, -101 lines 0 comments Download
D tools/clang/plugins/CheckIPCVisitor.cpp View 1 chunk +0 lines, -288 lines 0 comments Download
M tools/clang/plugins/FindBadConstructsAction.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M tools/clang/plugins/FindBadConstructsConsumer.h View 4 chunks +0 lines, -11 lines 0 comments Download
M tools/clang/plugins/FindBadConstructsConsumer.cpp View 2 chunks +0 lines, -33 lines 0 comments Download
M tools/clang/plugins/Options.h View 1 chunk +1 line, -1 line 0 comments Download
D tools/clang/plugins/tests/ipc.cpp View 1 chunk +0 lines, -351 lines 0 comments Download
D tools/clang/plugins/tests/ipc.flags View 1 chunk +0 lines, -1 line 0 comments Download
D tools/clang/plugins/tests/ipc.txt View 1 chunk +0 lines, -227 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Nico
Created Revert of Clang plugin to check that unstable types are not used in IPC.
4 years, 9 months ago (2016-03-10 15:13:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1783803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1783803002/1
4 years, 9 months ago (2016-03-10 15:13:46 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-10 15:14:20 UTC) #3
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 15:15:41 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fe36ec4d077c3a89979854bf37328dd41bb24ca6
Cr-Commit-Position: refs/heads/master@{#380408}

Powered by Google App Engine
This is Rietveld 408576698