Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: tools/clang/plugins/CMakeLists.txt

Issue 1783803002: Revert of Clang plugin to check that unstable types are not used in IPC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ipc/ipc_message_utils.h ('k') | tools/clang/plugins/CheckIPCVisitor.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 set(plugin_sources 1 set(plugin_sources
2 ChromeClassTester.cpp 2 ChromeClassTester.cpp
3 FindBadConstructsAction.cpp 3 FindBadConstructsAction.cpp
4 FindBadConstructsConsumer.cpp 4 FindBadConstructsConsumer.cpp)
5 CheckIPCVisitor.cpp)
6 5
7 if(WIN32) 6 if(WIN32)
8 # Clang doesn't support loadable modules on Windows. Unfortunately, building 7 # Clang doesn't support loadable modules on Windows. Unfortunately, building
9 # the plugin as a static library and linking clang against it doesn't work. 8 # the plugin as a static library and linking clang against it doesn't work.
10 # Since clang doesn't reference any symbols in our static library, the linker 9 # Since clang doesn't reference any symbols in our static library, the linker
11 # strips it out completely. 10 # strips it out completely.
12 # Instead, we rely on the fact that the SOURCES property of a target is no 11 # Instead, we rely on the fact that the SOURCES property of a target is no
13 # read-only after CMake 3.1 and use it to compile the plugin directly into 12 # read-only after CMake 3.1 and use it to compile the plugin directly into
14 # clang... 13 # clang...
15 cmake_minimum_required(VERSION 3.1) 14 cmake_minimum_required(VERSION 3.1)
(...skipping 13 matching lines...) Expand all
29 add_dependencies(libFindBadConstructs clang) 28 add_dependencies(libFindBadConstructs clang)
30 29
31 cr_install(TARGETS libFindBadConstructs LIBRARY DESTINATION lib) 30 cr_install(TARGETS libFindBadConstructs LIBRARY DESTINATION lib)
32 31
33 cr_add_test(plugins_test 32 cr_add_test(plugins_test
34 python tests/test.py 33 python tests/test.py
35 ${CMAKE_BINARY_DIR}/bin/clang 34 ${CMAKE_BINARY_DIR}/bin/clang
36 $<TARGET_FILE:libFindBadConstructs> 35 $<TARGET_FILE:libFindBadConstructs>
37 ) 36 )
38 endif() 37 endif()
OLDNEW
« no previous file with comments | « ipc/ipc_message_utils.h ('k') | tools/clang/plugins/CheckIPCVisitor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698