Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: tools/clang/plugins/FindBadConstructsConsumer.cpp

Issue 1783803002: Revert of Clang plugin to check that unstable types are not used in IPC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/clang/plugins/FindBadConstructsConsumer.h ('k') | tools/clang/plugins/Options.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/plugins/FindBadConstructsConsumer.cpp
diff --git a/tools/clang/plugins/FindBadConstructsConsumer.cpp b/tools/clang/plugins/FindBadConstructsConsumer.cpp
index 46c7b8f71d63f7cfe4be33ac54e41f985c2eaaaf..d1fc29df7ce5117d8a58fcf762917d730d7eddc0 100644
--- a/tools/clang/plugins/FindBadConstructsConsumer.cpp
+++ b/tools/clang/plugins/FindBadConstructsConsumer.cpp
@@ -103,10 +103,6 @@
FindBadConstructsConsumer::FindBadConstructsConsumer(CompilerInstance& instance,
const Options& options)
: ChromeClassTester(instance, options) {
- if (options.check_ipc) {
- ipc_visitor_.reset(new CheckIPCVisitor(instance));
- }
-
// Messages for virtual method specifiers.
diag_method_requires_override_ =
diagnostic().getCustomDiagID(getErrorLevel(), kMethodRequiresOverride);
@@ -140,39 +136,10 @@
DiagnosticsEngine::Note, kNoteProtectedNonVirtualDtor);
}
-void FindBadConstructsConsumer::Traverse(ASTContext& context) {
- if (ipc_visitor_) ipc_visitor_->set_context(&context);
- RecursiveASTVisitor::TraverseDecl(context.getTranslationUnitDecl());
- if (ipc_visitor_) ipc_visitor_->set_context(nullptr);
-}
-
-bool FindBadConstructsConsumer::shouldVisitTemplateInstantiations() const {
- return RecursiveASTVisitor::shouldVisitTemplateInstantiations() ||
- (ipc_visitor_ && ipc_visitor_->should_visit_template_instantiations());
-}
-
-bool FindBadConstructsConsumer::TraverseDecl(Decl* decl) {
- if (ipc_visitor_) ipc_visitor_->BeginDecl(decl);
- bool result = RecursiveASTVisitor::TraverseDecl(decl);
- if (ipc_visitor_) ipc_visitor_->EndDecl();
- return result;
-}
-
bool FindBadConstructsConsumer::VisitDecl(clang::Decl* decl) {
clang::TagDecl* tag_decl = dyn_cast<clang::TagDecl>(decl);
if (tag_decl && tag_decl->isCompleteDefinition())
CheckTag(tag_decl);
- return true;
-}
-
-bool FindBadConstructsConsumer::VisitTemplateSpecializationType(
- TemplateSpecializationType* spec) {
- if (ipc_visitor_) ipc_visitor_->VisitTemplateSpecializationType(spec);
- return true;
-}
-
-bool FindBadConstructsConsumer::VisitCallExpr(CallExpr* call_expr) {
- if (ipc_visitor_) ipc_visitor_->VisitCallExpr(call_expr);
return true;
}
« no previous file with comments | « tools/clang/plugins/FindBadConstructsConsumer.h ('k') | tools/clang/plugins/Options.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698