Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1783743002: [WebGL] a bunch of small fixes: unnecessary arguments, typos... (Closed)

Created:
4 years, 9 months ago by yunchao
Modified:
4 years, 9 months ago
CC:
chromium-reviews, blink-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[WebGL] a bunch of small fixes: unnecessary arguments, typos... BUG=295792 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel Committed: https://crrev.com/801186267c23a3e727f2aac27712bf7d3a620370 Cr-Commit-Position: refs/heads/master@{#380601}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M gpu/command_buffer/client/gles2_implementation.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 6 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 26 (14 generated)
yunchao
A bunch of small fixes. PTAL.
4 years, 9 months ago (2016-03-10 10:46:01 UTC) #5
Ken Russell (switch to Gerrit)
Blink changes LGTM; I'm not an owner of the command buffer files.
4 years, 9 months ago (2016-03-10 21:02:07 UTC) #6
Zhenyao Mo
On 2016/03/10 21:02:07, Ken Russell wrote: > Blink changes LGTM; I'm not an owner of ...
4 years, 9 months ago (2016-03-10 22:01:37 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1783743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1783743002/1
4 years, 9 months ago (2016-03-11 00:25:32 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/129200)
4 years, 9 months ago (2016-03-11 01:14:06 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1783743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1783743002/1
4 years, 9 months ago (2016-03-11 04:50:02 UTC) #14
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/195244)
4 years, 9 months ago (2016-03-11 07:07:07 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1783743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1783743002/1
4 years, 9 months ago (2016-03-11 09:11:53 UTC) #18
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-11 10:38:49 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1783743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1783743002/1
4 years, 9 months ago (2016-03-11 11:21:17 UTC) #22
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-11 11:26:10 UTC) #24
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 11:27:42 UTC) #26
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/801186267c23a3e727f2aac27712bf7d3a620370
Cr-Commit-Position: refs/heads/master@{#380601}

Powered by Google App Engine
This is Rietveld 408576698