third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp - Issue 1783743002: [WebGL] a bunch of small fixes: unnecessary arguments, typos...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp

Issue 1783743002: [WebGL] a bunch of small fixes: unnecessary arguments, typos... (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « gpu/command_buffer/service/gles2_cmd_decoder.cc ('k') | third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp

diff --git a/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp b/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp

index 786cdf5570d174182b494ba47c5df1f9bc204adf..b35095cab835271152ba4a745a1ae4dbf3ecfe03 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp

+++ b/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp

@@ -1524,7 +1524,7 @@ void WebGL2RenderingContextBase::vertexAttribDivisor(GLuint index, GLuint diviso

void WebGL2RenderingContextBase::drawArraysInstanced(GLenum mode, GLint first, GLsizei count, GLsizei instanceCount)

{

- if (!validateDrawArrays("drawArraysInstanced", mode, first, count))

+ if (!validateDrawArrays("drawArraysInstanced"))

return;

clearIfComposited();

@@ -1534,7 +1534,7 @@ void WebGL2RenderingContextBase::drawArraysInstanced(GLenum mode, GLint first, G

void WebGL2RenderingContextBase::drawElementsInstanced(GLenum mode, GLsizei count, GLenum type, long long offset, GLsizei instanceCount)

{

- if (!validateDrawElements("drawElementsInstanced", mode, count, type, offset))

+ if (!validateDrawElements("drawElementsInstanced", type, offset))

return;

if (transformFeedbackActive() && !transformFeedbackPaused()) {

@@ -1549,7 +1549,7 @@ void WebGL2RenderingContextBase::drawElementsInstanced(GLenum mode, GLsizei coun

void WebGL2RenderingContextBase::drawRangeElements(GLenum mode, GLuint start, GLuint end, GLsizei count, GLenum type, long long offset)

{

- if (!validateDrawElements("drawRangeElements", mode, count, type, offset))

+ if (!validateDrawElements("drawRangeElements", type, offset))

return;

if (transformFeedbackActive() && !transformFeedbackPaused()) {