gpu/command_buffer/service/gles2_cmd_decoder.cc - Issue 1783743002: [WebGL] a bunch of small fixes: unnecessary arguments, typos...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder.cc

Issue 1783743002: [WebGL] a bunch of small fixes: unnecessary arguments, typos... (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « gpu/command_buffer/client/gles2_implementation.cc ('k') | third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/service/gles2_cmd_decoder.cc

diff --git a/gpu/command_buffer/service/gles2_cmd_decoder.cc b/gpu/command_buffer/service/gles2_cmd_decoder.cc

index ca922438ca23ea5bbf51ee36d3400b98e8f397ff..c0f3b81d52111af67e1ec2a2b43b9b916ae7578f 100644

--- a/gpu/command_buffer/service/gles2_cmd_decoder.cc

+++ b/gpu/command_buffer/service/gles2_cmd_decoder.cc

@@ -7876,7 +7876,7 @@ bool GLES2DecoderImpl::SimulateAttrib0(

}

LOCAL_PERFORMANCE_WARNING(

- "Attribute 0 is disabled. This has signficant performance penalty");

+ "Attribute 0 is disabled. This has significant performance penalty");

LOCAL_COPY_REAL_GL_ERRORS_TO_WRAPPER(function_name);

glBindBuffer(GL_ARRAY_BUFFER, attrib_0_buffer_id_);

@@ -7965,7 +7965,7 @@ bool GLES2DecoderImpl::SimulateFixedAttribs(

}

LOCAL_PERFORMANCE_WARNING(

- "GL_FIXED attributes have a signficant performance penalty");

+ "GL_FIXED attributes have a significant performance penalty");

// NOTE: we could be smart and try to check if a buffer is used

// twice in 2 different attribs, find the overlapping parts and therefore