Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1783703003: X87: [wasm] Int64Lowering of I64ShrU and I64ShrS on ia32. (Closed)

Created:
4 years, 9 months ago by zhengxing.li
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [wasm] Int64Lowering of I64ShrU and I64ShrS on ia32. port 240b7db9c78685c603278bb1ac136b35de37b8c3 (r34630) original commit message: I implemented I64ShrU and I64ShrS the same as I64Shl in https://codereview.chromium.org/1756863002 BUG= Committed: https://crrev.com/25279332c78145da0b7c6e9052ceaedbacce1c42 Cr-Commit-Position: refs/heads/master@{#34656}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -32 lines) Patch
M src/compiler/x87/code-generator-x87.cc View 1 chunk +19 lines, -3 lines 0 comments Download
M src/compiler/x87/instruction-codes-x87.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/x87/instruction-selector-x87.cc View 1 chunk +41 lines, -3 lines 0 comments Download
M src/x87/assembler-x87.h View 1 chunk +5 lines, -6 lines 0 comments Download
M src/x87/assembler-x87.cc View 3 chunks +15 lines, -10 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/disasm-x87.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/x87/macro-assembler-x87.h View 1 chunk +6 lines, -2 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 3 chunks +46 lines, -2 lines 0 comments Download
M test/cctest/test-disasm-x87.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 9 months ago (2016-03-10 06:44:56 UTC) #2
Weiliang
lgtm
4 years, 9 months ago (2016-03-10 08:34:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1783703003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1783703003/1
4 years, 9 months ago (2016-03-10 08:35:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-10 09:37:04 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 09:39:46 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/25279332c78145da0b7c6e9052ceaedbacce1c42
Cr-Commit-Position: refs/heads/master@{#34656}

Powered by Google App Engine
This is Rietveld 408576698