[wasm] Int64Lowering of I64Shl on ia32.

[wasm] Int64Lowering of I64Shl on ia32.

I64Shl is lowered to a new turbofan operator, WasmWord64Shl. The new
operator takes 3 inputs, the low-word input, the high-word input, and
the shift, and produces 2 output, the low-word output and the high-word
output.

At the moment I implemented the lowering only for ia32, but I think the
CL is already big enough. I will add the other platforms in separate
CLs.

R=titzer@chromium.org

Committed: https://crrev.com/ddc626e1cf365261fa38cd3b91cbaf8b5e0444b9
Cr-Commit-Position: refs/heads/master@{#34546}

[ahaas, 2016-03-02 15:43:13]

On 2016/03/02 at 15:33:24, ahaas wrote:
> 

I removed some debug code.

[titzer, 2016-03-02 22:32:53]

lgtm other than naming changes

https://codereview.chromium.org/1756863002/diff/20001/src/compiler/instructio...
File src/compiler/instruction-selector.cc (right):

https://codereview.chromium.org/1756863002/diff/20001/src/compiler/instructio...
src/compiler/instruction-selector.cc:1151: return MarkAsWord32(node),
VisitWasmWord64Shl(node);
I don't think you want to do MarkAsWord32 here; you probably need to mark both
projections in the platform-specific methods.

https://codereview.chromium.org/1756863002/diff/20001/src/compiler/int64-lowe...
File src/compiler/int64-lowering.cc (right):

https://codereview.chromium.org/1756863002/diff/20001/src/compiler/int64-lowe...
src/compiler/int64-lowering.cc:293: DCHECK(node->InputCount() == 2);
Can you drop in a TODO(turbofan) here for shift count >= 32? In that case we can
just make the low word 0 and then only deal with the high word of the input.

https://codereview.chromium.org/1756863002/diff/20001/src/compiler/machine-op...
File src/compiler/machine-operator.h (right):

https://codereview.chromium.org/1756863002/diff/20001/src/compiler/machine-op...
src/compiler/machine-operator.h:182: const Operator* WasmWord64Shl();
Let's change the name to "Word32PairShl", since this isn't really WASM specific.

[ahaas, 2016-03-04 10:21:11]

https://codereview.chromium.org/1756863002/diff/20001/src/compiler/instructio...
File src/compiler/instruction-selector.cc (right):

https://codereview.chromium.org/1756863002/diff/20001/src/compiler/instructio...
src/compiler/instruction-selector.cc:1151: return MarkAsWord32(node),
VisitWasmWord64Shl(node);
On 2016/03/02 at 22:32:53, titzer wrote:
> I don't think you want to do MarkAsWord32 here; you probably need to mark both
projections in the platform-specific methods.

Done. PTAL here, I'm not sure I understood you correctly.

https://codereview.chromium.org/1756863002/diff/20001/src/compiler/int64-lowe...
File src/compiler/int64-lowering.cc (right):

https://codereview.chromium.org/1756863002/diff/20001/src/compiler/int64-lowe...
src/compiler/int64-lowering.cc:293: DCHECK(node->InputCount() == 2);
On 2016/03/02 at 22:32:53, titzer wrote:
> Can you drop in a TODO(turbofan) here for shift count >= 32? In that case we
can just make the low word 0 and then only deal with the high word of the input.

Done.

https://codereview.chromium.org/1756863002/diff/20001/src/compiler/machine-op...
File src/compiler/machine-operator.h (right):

https://codereview.chromium.org/1756863002/diff/20001/src/compiler/machine-op...
src/compiler/machine-operator.h:182: const Operator* WasmWord64Shl();
On 2016/03/02 at 22:32:53, titzer wrote:
> Let's change the name to "Word32PairShl", since this isn't really WASM
specific.

Done.

[ahaas, 2016-03-07 15:15:36]

The CQ bit was checked by ahaas@chromium.org

[ahaas, 2016-03-07 15:15:36]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/1756863002/#ps100001
(title: "Forgot to turn off the test for arm.")

[commit-bot: I haz the power, 2016-03-07 15:15:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1756863002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1756863002/100001

[commit-bot: I haz the power, 2016-03-07 15:17:59]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-03-07 15:19:47]

Description was changed from

==========
[wasm] Int64Lowering of I64Shl on ia32.

I64Shl is lowered to a new turbofan operator, WasmWord64Shl. The new
operator takes 3 inputs, the low-word input, the high-word input, and
the shift, and produces 2 output, the low-word output and the high-word
output.

At the moment I implemented the lowering only for ia32, but I think the
CL is already big enough. I will add the other platforms in separate
CLs.

R=titzer@chromium.org
==========

to

==========
[wasm] Int64Lowering of I64Shl on ia32.

I64Shl is lowered to a new turbofan operator, WasmWord64Shl. The new
operator takes 3 inputs, the low-word input, the high-word input, and
the shift, and produces 2 output, the low-word output and the high-word
output.

At the moment I implemented the lowering only for ia32, but I think the
CL is already big enough. I will add the other platforms in separate
CLs.

R=titzer@chromium.org

Committed: https://crrev.com/ddc626e1cf365261fa38cd3b91cbaf8b5e0444b9
Cr-Commit-Position: refs/heads/master@{#34546}
==========

[commit-bot: I haz the power, 2016-03-07 15:19:48]

Patchset 6 (id:??) landed as
https://crrev.com/ddc626e1cf365261fa38cd3b91cbaf8b5e0444b9
Cr-Commit-Position: refs/heads/master@{#34546}