Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1783693006: Use <string> serialization rules for computed value of reference filter (Closed)

Created:
4 years, 9 months ago by rwlbuis
Modified:
4 years, 9 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, shans, rjwright, blink-reviews-style_chromium.org, blink-reviews-animation_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis, Eric Willigers, nainar
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use <string> serialization rules for computed value of reference filter According to [1] the filter reference is a <url> type. For <url> types the spec says to use <string>s [2]. And <string>s serialize with double quotes. Also remove the unused quoteCSSURLIfNeeded. Behavior matches Firefox. [1] https://drafts.fxtf.org/filters/#typedef-filter-function-list [2] https://www.w3.org/TR/css-values/#urls [3] https://drafts.csswg.org/cssom/#serialize-a-string Committed: https://crrev.com/b2be3f36e2f4ba3db981809d6252b4148295d238 Cr-Commit-Position: refs/heads/master@{#380517}

Patch Set 1 #

Patch Set 2 : Fix tests #

Messages

Total messages: 32 (17 generated)
rwlbuis
PTAL. Not sure if this needs a bug, I discovered this while starting to work ...
4 years, 9 months ago (2016-03-10 23:21:04 UTC) #5
Timothy Loh
lgtm
4 years, 9 months ago (2016-03-10 23:24:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1783693006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1783693006/20001
4 years, 9 months ago (2016-03-10 23:36:10 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/138136) linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 9 months ago (2016-03-11 00:09:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1783693006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1783693006/20001
4 years, 9 months ago (2016-03-11 00:26:09 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/179855)
4 years, 9 months ago (2016-03-11 00:59:13 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1783693006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1783693006/20001
4 years, 9 months ago (2016-03-11 01:08:58 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/193697)
4 years, 9 months ago (2016-03-11 01:30:37 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1783693006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1783693006/20001
4 years, 9 months ago (2016-03-11 02:31:43 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/180013)
4 years, 9 months ago (2016-03-11 03:07:42 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1783693006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1783693006/20001
4 years, 9 months ago (2016-03-11 03:44:03 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/129389)
4 years, 9 months ago (2016-03-11 04:26:07 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1783693006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1783693006/20001
4 years, 9 months ago (2016-03-11 04:27:43 UTC) #28
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-11 05:16:44 UTC) #30
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 05:18:12 UTC) #32
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b2be3f36e2f4ba3db981809d6252b4148295d238
Cr-Commit-Position: refs/heads/master@{#380517}

Powered by Google App Engine
This is Rietveld 408576698