third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp - Issue 1783693006: Use <string> serialization rules for computed value of reference filter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

Issue 1783693006: Use <string> serialization rules for computed value of reference filter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix tests Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

diff --git a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

index 719b130eb16cf5be0a478e5f495ac0f6d32263fd..c855c5c38fe7796894133f7475df68eea9afad5d 100644

--- a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

+++ b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

@@ -1213,7 +1213,7 @@ PassRefPtrWillBeRawPtr<CSSValue> ComputedStyleCSSValueMapping::valueForFilter(co

switch (filterOperation->type()) {

case FilterOperation::REFERENCE:

filterValue = CSSFunctionValue::create(CSSValueUrl);

- filterValue->append(CSSCustomIdentValue::create(toReferenceFilterOperation(filterOperation)->url()));

+ filterValue->append(CSSStringValue::create(toReferenceFilterOperation(filterOperation)->url()));

break;

case FilterOperation::GRAYSCALE:

filterValue = CSSFunctionValue::create(CSSValueGrayscale);

« no previous file with comments | « third_party/WebKit/Source/core/css/CSSMarkup.cpp ('k') | no next file » | no next file with comments »