Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Side by Side Diff: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

Issue 1783693006: Use <string> serialization rules for computed value of reference filter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix tests Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/css/CSSMarkup.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004 Zack Rusin <zack@kde.org> 2 * Copyright (C) 2004 Zack Rusin <zack@kde.org>
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
4 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 4 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
5 * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com> 5 * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com>
6 * Copyright (C) 2011 Sencha, Inc. All rights reserved. 6 * Copyright (C) 2011 Sencha, Inc. All rights reserved.
7 * Copyright (C) 2015 Google Inc. All rights reserved. 7 * Copyright (C) 2015 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Lesser General Public 10 * modify it under the terms of the GNU Lesser General Public
(...skipping 1195 matching lines...) Expand 10 before | Expand all | Expand 10 after
1206 1206
1207 RefPtrWillBeRawPtr<CSSValueList> list = CSSValueList::createSpaceSeparated() ; 1207 RefPtrWillBeRawPtr<CSSValueList> list = CSSValueList::createSpaceSeparated() ;
1208 1208
1209 RefPtrWillBeRawPtr<CSSFunctionValue> filterValue = nullptr; 1209 RefPtrWillBeRawPtr<CSSFunctionValue> filterValue = nullptr;
1210 1210
1211 for (const auto& operation : filterOperations.operations()) { 1211 for (const auto& operation : filterOperations.operations()) {
1212 FilterOperation* filterOperation = operation.get(); 1212 FilterOperation* filterOperation = operation.get();
1213 switch (filterOperation->type()) { 1213 switch (filterOperation->type()) {
1214 case FilterOperation::REFERENCE: 1214 case FilterOperation::REFERENCE:
1215 filterValue = CSSFunctionValue::create(CSSValueUrl); 1215 filterValue = CSSFunctionValue::create(CSSValueUrl);
1216 filterValue->append(CSSCustomIdentValue::create(toReferenceFilterOpe ration(filterOperation)->url())); 1216 filterValue->append(CSSStringValue::create(toReferenceFilterOperatio n(filterOperation)->url()));
1217 break; 1217 break;
1218 case FilterOperation::GRAYSCALE: 1218 case FilterOperation::GRAYSCALE:
1219 filterValue = CSSFunctionValue::create(CSSValueGrayscale); 1219 filterValue = CSSFunctionValue::create(CSSValueGrayscale);
1220 filterValue->append(cssValuePool().createValue(toBasicColorMatrixFil terOperation(filterOperation)->amount(), CSSPrimitiveValue::UnitType::Number)); 1220 filterValue->append(cssValuePool().createValue(toBasicColorMatrixFil terOperation(filterOperation)->amount(), CSSPrimitiveValue::UnitType::Number));
1221 break; 1221 break;
1222 case FilterOperation::SEPIA: 1222 case FilterOperation::SEPIA:
1223 filterValue = CSSFunctionValue::create(CSSValueSepia); 1223 filterValue = CSSFunctionValue::create(CSSValueSepia);
1224 filterValue->append(cssValuePool().createValue(toBasicColorMatrixFil terOperation(filterOperation)->amount(), CSSPrimitiveValue::UnitType::Number)); 1224 filterValue->append(cssValuePool().createValue(toBasicColorMatrixFil terOperation(filterOperation)->amount(), CSSPrimitiveValue::UnitType::Number));
1225 break; 1225 break;
1226 case FilterOperation::SATURATE: 1226 case FilterOperation::SATURATE:
(...skipping 1524 matching lines...) Expand 10 before | Expand all | Expand 10 after
2751 case CSSPropertyAll: 2751 case CSSPropertyAll:
2752 return nullptr; 2752 return nullptr;
2753 default: 2753 default:
2754 break; 2754 break;
2755 } 2755 }
2756 ASSERT_NOT_REACHED(); 2756 ASSERT_NOT_REACHED();
2757 return nullptr; 2757 return nullptr;
2758 } 2758 }
2759 2759
2760 } // namespace blink 2760 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/css/CSSMarkup.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698