Use buildername rather than slavename for "bot" with perf dashboard.

Use buildername rather than slavename for "bot" with perf dashboard.

Rationale: This is what is used most commonly for the "bot" names on the perf dashboard, and the builder name usually gives a clearer idea of the platform (rather than the slave name, which often doesn't tell you the platform and can change if buildslaves are changed).

The libvpx/android_unittest recipe uses the perf_dashboard recipe module; this CL changes that recipe to explicitly pass the slave name since that is what it has done in the past. Note that the expectations don't change for that recipe.

BUG=593431
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299231

[qyearsley, 2016-03-10 01:02:58]

qyearsley@chromium.org changed reviewers:
+ chrisphan@chromium.org

[chrisphan, 2016-03-10 19:13:03]

lgtm

[qyearsley, 2016-03-10 19:14:22]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2016-03-10 19:14:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1782723002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1782723002/1

[commit-bot: I haz the power, 2016-03-10 19:20:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-10 19:20:41]

Try jobs failed on following builders:
  Build Presubmit on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/build...)

[qyearsley, 2016-03-10 22:14:49]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-10 22:14:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1782723002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1782723002/20001

[qyearsley, 2016-03-10 22:17:11]

Description was changed from

==========
Use buildername rather than slavename for "bot" with perf dashboard.

BUG=593431
==========

to

==========
Use buildername rather than slavename for "bot" with perf dashboard.

Rationale: This is what is used most commonly for the "bot" names on the perf
dashboard, and the builder name usually gives a clearer idea of the platform
(rather than the slave name, which often doesn't tell you the platform and can
change if buildslaves are changed).

The libvpx/android_unittest recipe uses the perf_dashboard recipe module; this
CL changes that recipe to explicitly pass the slave name since that is what it
has done in the past. Note that the expectations don't change for that recipe.

BUG=593431
==========

[qyearsley, 2016-03-10 22:17:11]

qyearsley@chromium.org changed reviewers:
+ joshualitt@chromium.org

[commit-bot: I haz the power, 2016-03-10 22:20:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-10 22:20:48]

Dry run: This issue passed the CQ dry run.

[qyearsley, 2016-03-10 22:37:33]

qyearsley@chromium.org changed reviewers:
+ tomfinegan@chromium.org
- joshualitt@chromium.org

[qyearsley, 2016-03-10 22:38:05]

On 2016/03/10 at 22:20:48, commit-bot wrote:
> Dry run: This issue passed the CQ dry run.

tomfinegan@, this CL will require OWNERS approval for the change in
recipes/libvpx; could you take a quick look?

[Tom Finegan, 2016-03-10 22:44:01]

On 2016/03/10 22:38:05, qyearsley wrote:
> On 2016/03/10 at 22:20:48, commit-bot wrote:
> > Dry run: This issue passed the CQ dry run.
> 
> tomfinegan@, this CL will require OWNERS approval for the change in
> recipes/libvpx; could you take a quick look?

lgtm

And, sorry... forgot I owned the libvpx sub dir (inherited from former team
member). Feel free to ping me sooner in the future.

[qyearsley, 2016-03-10 23:15:04]

On 2016/03/10 at 22:44:01, tomfinegan wrote:
> On 2016/03/10 22:38:05, qyearsley wrote:
> > On 2016/03/10 at 22:20:48, commit-bot wrote:
> > > Dry run: This issue passed the CQ dry run.
> > 
> > tomfinegan@, this CL will require OWNERS approval for the change in
> > recipes/libvpx; could you take a quick look?
> 
> lgtm
> 
> And, sorry... forgot I owned the libvpx sub dir (inherited from former team
member). Feel free to ping me sooner in the future.

NP, thanks

[qyearsley, 2016-03-10 23:15:06]

The CQ bit was checked by qyearsley@chromium.org

[qyearsley, 2016-03-10 23:15:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrisphan@chromium.org
Link to the patchset: https://codereview.chromium.org/1782723002/#ps20001
(title: "Allow recipe to specify bot name in skeleton point.")

[commit-bot: I haz the power, 2016-03-10 23:15:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1782723002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1782723002/20001

[joshualitt, 2016-03-10 23:18:15]

On 2016/03/10 23:15:09, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1782723002/20001
> View timeline at
>  https://chromium-cq-status.appspot.com/patch-timeline/1782723002/20001

lgtm

[commit-bot: I haz the power, 2016-03-10 23:19:07]

Description was changed from

==========
Use buildername rather than slavename for "bot" with perf dashboard.

Rationale: This is what is used most commonly for the "bot" names on the perf
dashboard, and the builder name usually gives a clearer idea of the platform
(rather than the slave name, which often doesn't tell you the platform and can
change if buildslaves are changed).

The libvpx/android_unittest recipe uses the perf_dashboard recipe module; this
CL changes that recipe to explicitly pass the slave name since that is what it
has done in the past. Note that the expectations don't change for that recipe.

BUG=593431
==========

to

==========
Use buildername rather than slavename for "bot" with perf dashboard.

Rationale: This is what is used most commonly for the "bot" names on the perf
dashboard, and the builder name usually gives a clearer idea of the platform
(rather than the slave name, which often doesn't tell you the platform and can
change if buildslaves are changed).

The libvpx/android_unittest recipe uses the perf_dashboard recipe module; this
CL changes that recipe to explicitly pass the slave name since that is what it
has done in the past. Note that the expectations don't change for that recipe.

BUG=593431

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299231
==========

[commit-bot: I haz the power, 2016-03-10 23:19:08]

Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299231