Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Unified Diff: scripts/slave/recipe_modules/perf_dashboard/api.py

Issue 1782723002: Use buildername rather than slavename for "bot" with perf dashboard. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Allow recipe to specify bot name in skeleton point. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/perf_dashboard/example.expected/linux.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/perf_dashboard/api.py
diff --git a/scripts/slave/recipe_modules/perf_dashboard/api.py b/scripts/slave/recipe_modules/perf_dashboard/api.py
index 1b105a24c019cf1489fc65ed2cbb15c8a8029e82..8caa6250f033ce9e3a565d909a08a1b3e2e502f6 100644
--- a/scripts/slave/recipe_modules/perf_dashboard/api.py
+++ b/scripts/slave/recipe_modules/perf_dashboard/api.py
@@ -11,14 +11,14 @@ class PerfDashboardApi(recipe_api.RecipeApi):
"""Provides steps to take a list of perf points and post them to the
Chromium Perf Dashboard. Can also use the test url for testing purposes."""
- def get_skeleton_point(self, test, revision, value):
+ def get_skeleton_point(self, test, revision, value, bot=None):
# TODO: masterid is really mastername
assert (test != '')
assert (revision != '')
assert (value != '')
return {
'master': self.m.properties['mastername'],
- 'bot': self.m.properties['slavename'],
+ 'bot': bot or self.m.properties['buildername'],
'test': test,
'revision': revision,
'value': value,
@@ -39,14 +39,14 @@ class PerfDashboardApi(recipe_api.RecipeApi):
step_result.presentation from a followup_fn of a step.
test: Slash-separated test path.
revision: The build revision, e.g. got_revision from the update step.
- bot: The slave name.
+ bot: The bot name used for the data on the perf dashboard.
"""
assert presentation
assert test
assert revision
params = urllib.urlencode({
'masters': self.m.properties['mastername'],
- 'bots': bot or self.m.properties['slavename'],
+ 'bots': bot or self.m.properties['buildername'],
'tests': test,
'rev': revision,
})
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/perf_dashboard/example.expected/linux.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698