scripts/slave/recipes/libvpx/android_unittests.py - Issue 1782723002: Use buildername rather than slavename for "bot" with perf dashboard.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/libvpx/android_unittests.py

Issue 1782723002: Use buildername rather than slavename for "bot" with perf dashboard. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Allow recipe to specify bot name in skeleton point. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/recipes/libvpx/android_unittests.py

diff --git a/scripts/slave/recipes/libvpx/android_unittests.py b/scripts/slave/recipes/libvpx/android_unittests.py

index 86daabfef30f052312b59eef55fada2e57c90c9a..f6ac89e08dc29a7b53d59b5a32147b8504edf3c0 100644

--- a/scripts/slave/recipes/libvpx/android_unittests.py

+++ b/scripts/slave/recipes/libvpx/android_unittests.py

@@ -149,23 +149,32 @@ def RunSteps(api, libvpx_git_url, buildername):

# Two data points for encoder tests, FPS and minPsnr

testname = "libvpx/encode/perf_test/fps/" + device + "/"

testname = testname + i["videoName"] + "_" + str(i["speed"])

- p = api.perf_dashboard.get_skeleton_point(testname,

- libvpx_revision_number, i["framesPerSecond"])

+ p = api.perf_dashboard.get_skeleton_point(

+ testname,

+ libvpx_revision_number,

+ i["framesPerSecond"],

+ bot=api.m.properties["slavename"])

p['units'] = "fps"

points.append(p)

#minPsnr

testname = "libvpx/encode/perf_test/minPsnr/" + device + "/"

testname = testname + i["videoName"] + "_" + str(i["speed"])

- p = api.perf_dashboard.get_skeleton_point(testname,

- libvpx_revision_number, i["minPsnr"])

+ p = api.perf_dashboard.get_skeleton_point(

+ testname,

+ libvpx_revision_number,

+ i["minPsnr"],

+ bot=api.m.properties["slavename"])

p['units'] = "dB"

points.append(p)

else:

testname = "libvpx/decode/perf_test/" + device + "/"

testname = testname + i["videoName"] + "_" + str(i["threadCount"])

- p = api.perf_dashboard.get_skeleton_point(testname,

- libvpx_revision_number, i["framesPerSecond"])

+ p = api.perf_dashboard.get_skeleton_point(

+ testname,

+ libvpx_revision_number,

+ i["framesPerSecond"],

+ bot=api.m.properties["slavename"])

p['units'] = "fps"

points.append(p)

« no previous file with comments | « scripts/slave/recipe_modules/perf_dashboard/example.expected/win_use_mirror.json ('k') | no next file » | no next file with comments »