Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issue 1782703002: sk_sp versions of newWithColorFilter and newWithLocalMatrix (Closed)

Created:
4 years, 9 months ago by reed1
Modified:
4 years, 9 months ago
Reviewers:
f(malita)
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -19 lines) Patch
M gm/colorfilterimagefilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/perlinnoise.cpp View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkShader.h View 2 chunks +9 lines, -2 lines 0 comments Download
M samplecode/SamplePatch.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M src/core/SkBlitter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkColorFilterShader.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/core/SkLocalMatrixShader.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M tests/SkColor4fTest.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
reed1
4 years, 9 months ago (2016-03-10 02:30:30 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782703002/1
4 years, 9 months ago (2016-03-10 02:30:36 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-10 02:46:57 UTC) #7
f(malita)
lgtm
4 years, 9 months ago (2016-03-10 14:04:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782703002/1
4 years, 9 months ago (2016-03-10 14:35:48 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 14:36:53 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/150835e779ceb24e2b540f58958cbff2a0ab9942

Powered by Google App Engine
This is Rietveld 408576698