tests/SkColor4fTest.cpp - Issue 1782703002: sk_sp versions of newWithColorFilter and newWithLocalMatrix

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/SkColor4fTest.cpp

Issue 1782703002: sk_sp versions of newWithColorFilter and newWithLocalMatrix (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/SkColor4fTest.cpp

diff --git a/tests/SkColor4fTest.cpp b/tests/SkColor4fTest.cpp

index 62eed211dfdbc5b412839bc0d48be316a968922e..0b5a4e05f7d6adf90ffbe13487039b0cb530b5df 100644

--- a/tests/SkColor4fTest.cpp

+++ b/tests/SkColor4fTest.cpp

@@ -125,8 +125,7 @@ static sk_sp<SkShader> make_grad_sh() {

static sk_sp<SkShader> make_cf_sh() {

SkAutoTUnref<SkColorFilter> filter(make_mx_cf());

- sk_sp<SkShader> shader(make_color_sh());

- return sk_sp<SkShader>(shader->newWithColorFilter(filter));

+ return make_color_sh()->makeWithColorFilter(filter);

}

static bool compare_spans(const SkPM4f span4f[], const SkPMColor span4b[], int count,

« no previous file with comments | « src/core/SkLocalMatrixShader.cpp ('k') | no next file » | no next file with comments »